Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

known limitation: when running with --inspect=localhost:0 only one port is printed #13772

Closed
refack opened this issue Jun 19, 2017 · 6 comments
Closed
Labels
cli Issues and PRs related to the Node.js command line interface. feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol

Comments

@refack
Copy link
Contributor

refack commented Jun 19, 2017

  • Version: 9-pre
  • Platform: *
  • Subsystem: inspector,cli

A know limitation after #13478
If node is started with a hostname and port 0, the process will possibly bind 2 sockets with two different ports, but print only one

d:\code\node-cur$ node9pre.exe --inspect=localhost:0
Debugger listening on ws://localhost:63448/38595be5-d6d8-4142-bdbb-25133971f734
For help see https://nodejs.org/en/docs/inspector
>

image

@refack refack added cli Issues and PRs related to the Node.js command line interface. inspector Issues and PRs related to the V8 inspector protocol known limitation Issues that are identified as known limitations. labels Jun 19, 2017
@eugeneo
Copy link
Contributor

eugeneo commented Jun 19, 2017

My understanding is that the console output (e.g. the "Debugger listening on ws://localhost:63448/38595be5-d6d8-4142-bdbb-25133971f734") message is pretty much considered an API as other software may be parsing the output. I can change the output to include multiple ports/hosts - but I would like to discuss the suggested format.

@sam-github
Copy link
Contributor

I don't think the output format should be changed, the message should just be repeated in a loop, once for each listen that was done in InspectorSoketServer::Start()

@sam-github
Copy link
Contributor

And to be clear, I don't think thats semver-major. Any code grepping output will find one of the instances, first or last, who knows (but its random right now which of the server socket addresses is printed anyway).

@targos
Copy link
Member

targos commented Nov 4, 2018

@refack What would you like to do with this? I suggest either close as a known limitation or promote to a feature request (print multiple lines).

@bnoordhuis bnoordhuis added feature request Issues that request new features to be added to Node.js. and removed known limitation Issues that are identified as known limitations. labels Feb 8, 2019
@bnoordhuis
Copy link
Member

I'm relabeling this feature request, it seems useful.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Feb 8, 2019
Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.

No test. I can't think of a reliable way to test this on the CI matrix.

Fixes: nodejs#13772
@bnoordhuis
Copy link
Member

#26008

BridgeAR pushed a commit that referenced this issue Mar 4, 2019
Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.

No test. I can't think of a reliable way to test this on the CI matrix.

PR-URL: #26008
Fixes: #13772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this issue Mar 5, 2019
Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.

No test. I can't think of a reliable way to test this on the CI matrix.

PR-URL: #26008
Fixes: #13772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 16, 2019
Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.

No test. I can't think of a reliable way to test this on the CI matrix.

PR-URL: #26008
Fixes: #13772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

5 participants