Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: implement a way to regularly test abort behaviour on all platform #14012

Closed
refack opened this issue Jun 30, 2017 · 4 comments · Fixed by #15056
Closed

test: implement a way to regularly test abort behaviour on all platform #14012

refack opened this issue Jun 30, 2017 · 4 comments · Fixed by #15056
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented Jun 30, 2017 •
edited
Loading

  • Version: *
  • Platform: *
  • Subsystem: process,test

Since testing abort() and --abort-on-uncaught-exception generate core-dump that take allot of storage they have been moved to test/abort/ and are not regularly tested on the full repertoire of platforms that we support.

/cc @nodejs/testing @nodejs/build
@refack refack added process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. labels Jun 30, 2017
@refack refack mentioned this issue Jun 30, 2017
Closed
3 tasks
@refack
Copy link
Contributor Author

refack commented Jun 30, 2017

Recently we had at least 3 cases of bit-rot on 3 different platforms
Ref: alpine@docker — #13985 (comment)
Ref: macOS — #13527
Ref: Windows — #13947

@refack
Copy link
Contributor Author

refack commented Jun 30, 2017

One suggestion that came up was to programmatically disable the creation of core-dumps (for all the tests of for some suites). Or alternatively to implement a way to delete the core-dump from within the test a la common.refreshTmpDir().

@Trott Trott mentioned this issue Jun 30, 2017
Closed
2 tasks
Trott added a commit to Trott/io.js that referenced this issue Aug 26, 2017
@Trott
test: run abort tests
66b9ab6 
Currently, tests in test/abort do not run in CI.

This change configures the test runner to not write core files for abort
tests and to run them.

Fixes: nodejs#14012
@Trott Trott closed this as completed in 70c775a Aug 26, 2017
@Trott
Copy link
Member

Trott commented Aug 26, 2017

70c775a closed this but it might be worth re-opening on the grounds that while it enables the abort tests in CI on all other platforms, it does not enable them on Windows.

@refack
Copy link
Contributor Author

refack commented Aug 28, 2017 •
edited
Loading

It's a paradoxical situation.
On the one hand core dumps are not regularly generated for Windows - so no need to disable them.
On the other hand core dumps are not regularly generated on Windows - need to find a way to enable them.

P.S. IMHO that's a new issue.

@refack refack mentioned this issue Aug 28, 2017
Merged
3 tasks
ghost pushed a commit to ayojs/ayo that referenced this issue Aug 30, 2017
@Trott
test: run abort tests
f0eca07 
Currently, tests in test/abort do not run in CI.

This change configures the test runner to not write core files for abort
tests and to run them.

PR-URL: nodejs/node#14013
Fixes: nodejs/node#14012
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this issue Aug 30, 2017
@Trott
test: run abort tests
c4ac579 
Currently, tests in test/abort do not run in CI.

This change configures the test runner to not write core files for abort
tests and to run them.

PR-URL: nodejs/node#14013
Fixes: nodejs/node#14012
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack added a commit to refack/node that referenced this issue Sep 3, 2017
@refack
test,process: run 'abort' suite on Windows
233d1e2 
PR-URL: nodejs#15056
Fixes: nodejs#14012
Refs: nodejs#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 5, 2017
@addaleax
test,process: run 'abort' suite on Windows
49da82c 
PR-URL: nodejs/node#15056
Fixes: nodejs/node#14012
Refs: nodejs/node#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@Trott @MylesBorins
test: run abort tests
7186f1c 
Currently, tests in test/abort do not run in CI.

This change configures the test runner to not write core files for abort
tests and to run them.

PR-URL: #14013
Fixes: #14012
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@refack @MylesBorins
test,process: run 'abort' suite on Windows
c3e4c12 
PR-URL: #15056
Fixes: #14012
Refs: #14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@Trott @MylesBorins
test: run abort tests
f89ef77 
Currently, tests in test/abort do not run in CI.

This change configures the test runner to not write core files for abort
tests and to run them.

PR-URL: #14013
Fixes: #14012
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack added a commit to refack/node that referenced this issue Sep 23, 2017
@refack
test,process: run 'abort' suite on Windows
26f2755 
PR-URL: nodejs#15056
Fixes: nodejs#14012
Refs: nodejs#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit that referenced this issue Sep 25, 2017
@refack @jasnell
test,process: run 'abort' suite on Windows
e014983 
PR-URL: #15056
Fixes: #14012
Refs: #14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack refack mentioned this issue Oct 24, 2017
Closed
2 tasks
refack added a commit to refack/node that referenced this issue Oct 24, 2017
@refack
test,process: run 'abort' suite on Windows
d862064 
PR-URL: nodejs#15056
Fixes: nodejs#14012
Refs: nodejs#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@refack @MylesBorins
test,process: run 'abort' suite on Windows
54286db 
Backport-PR-URL: #16442
PR-URL: #15056
Fixes: #14012
Refs: #14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@refack @MylesBorins
test,process: run 'abort' suite on Windows
3e96c85 
Backport-PR-URL: #16442
PR-URL: #15056
Fixes: #14012
Refs: #14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 26, 2017
@refack @MylesBorins
test,process: run 'abort' suite on Windows
e0c4f0b 
Backport-PR-URL: #16442
PR-URL: #15056
Fixes: #14012
Refs: #14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: run 'abort' suite on Windows refack/node
test: run abort tests Trott/io.js
2 participants
@refack @Trott