-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process,Windows: fix docs for spawn({shell})
#14156
Comments
/cc @nodejs/platform-windows @nodejs/documentation |
This is one of many problems arising from setting weird environments for child processes. Technically, the documentation is not entirely incorrect. Microsoft specifies that |
I think we should say that the value defaults to |
Ref #14157 |
Clarifies the default shell in Windows is process.env.ComSpec and that cmd.exe is only used as a fallback. Functions whose descriptions are affected include: child_process.spawn, child_process.exec, child_process.spawnsSync, and child_process.execSync. Fixes: nodejs#14156
Clarifies that the default shell in Windows is process.env.ComSpec and that cmd.exe is only used as a fallback. Functions whose descriptions are affected include: child_process.spawn, child_process.exec, child_process.spawnSync, and child_process.execSync. Fixes: nodejs#14156
Reorganizes `child_process` shell spawning information. Fixes: nodejs#14156
Small formatting fixes for shell spawning information. Fixes: nodejs#14156
Notation changes for `process.env.ComSpec` Fixes: nodejs#14156
Wrapped `%COMSPEC%` with percent signs. Fixes: nodejs#14156
Clarifies the default shell in Windows is process.env.ComSpec and that cmd.exe is only used as a fallback. Functions whose descriptions are affected include: child_process.spawn, child_process.exec, child_process.spawnsSync, and child_process.execSync. PR-URL: #14203 Fixes: #14156 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Clarifies the default shell in Windows is process.env.ComSpec and that cmd.exe is only used as a fallback. Functions whose descriptions are affected include: child_process.spawn, child_process.exec, child_process.spawnsSync, and child_process.execSync. PR-URL: #14203 Fixes: #14156 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options erronously states that
cmd.exe
is the defaultshell
for windows, while infact it'sprocess.env.ComSpec
.The same goes for:
The text was updated successfully, but these errors were encountered: