Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: parallel/test-zlib-failed-init, intermittent crash #14178

Closed
mhdawson opened this issue Jul 11, 2017 · 18 comments
Closed

test: parallel/test-zlib-failed-init, intermittent crash #14178

mhdawson opened this issue Jul 11, 2017 · 18 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. zlib Issues and PRs related to the zlib subsystem.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jul 11, 2017 •
edited by refack
Loading

  • Version: master
  • Platform: Windows, debian8
  • Subsystem: zlib

Crash in run for unrelated PR
https://ci.nodejs.org/job/node-test-binary-windows/9757/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2012r2/console

not ok 358 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.806
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED
  ...
@mhdawson mhdawson mentioned this issue Jul 11, 2017
Closed
2 tasks
@refack refack added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 11, 2017
@refack
Copy link
Contributor

refack commented Jul 11, 2017

Might be dup of #14161

@mscdex mscdex added the zlib Issues and PRs related to the zlib subsystem. label Jul 11, 2017
@refack
Copy link
Contributor

refack commented Jul 12, 2017

https://ci.nodejs.org/job/node-test-binary-windows/9762/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2012r2/

@refack refack mentioned this issue Jul 12, 2017
Merged
3 tasks
@Trott
Copy link
Member

Trott commented Jul 12, 2017

Two more:

https://ci.nodejs.org/job/node-test-binary-windows/9786/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2012r2/console

not ok 358 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.801
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED

https://ci.nodejs.org/job/node-test-binary-windows/9786/RUN_SUBSET=1,VS_VERSION=vcbt2015,label=win10/console:

not ok 358 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.529
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED

@Trott
Copy link
Member

Trott commented Jul 12, 2017

Signs allegedly point to 09d579f. /cc @mscdex

@Trott
Copy link
Member

Trott commented Jul 12, 2017

This issue has been observed on both Azure and Rackspace hosts in CI.

@refack refack mentioned this issue Jul 23, 2017
Closed
3 tasks
@Trott
Copy link
Member

Trott commented Jul 24, 2017

Saw another one today...

https://ci.nodejs.org/job/node-test-binary-windows/10066/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2012r2/console

not ok 362 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.477
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED

@nodejs/platform-windows

@Trott Trott added the windows Issues and PRs related to the Windows platform. label Jul 24, 2017
@Trott
Copy link
Member

Trott commented Jul 25, 2017

Also this one:

https://ci.nodejs.org/job/node-test-binary-windows/10047/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/console

not ok 361 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.491
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED

@Trott
Copy link
Member

Trott commented Jul 25, 2017

Pinging folks who have worked on the test file: @aqrln @danbev

@refack
Copy link
Contributor

refack commented Jul 29, 2017 •
edited
Loading

Hello debian8:

not ok 1452 parallel/test-zlib-failed-init
  ---
  duration_ms: 0.109
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)
  ...

https://ci.nodejs.org/job/node-test-commit-linux/11480/nodes=debian8-x86/

@refack refack changed the title parallel/test-zlib-failed-init, intermittent crash on windows ? test: parallel/test-zlib-failed-init, intermittent crash Jul 29, 2017
@refack refack mentioned this issue Jul 29, 2017
Closed
8 tasks
@refack
Copy link
Contributor

refack commented Jul 29, 2017

@addaleax, @bnoordhuis, @indutny
Now that it's not just a Windows failure, the "onboarding-extra" guide sais to ping you

(test code)

@addaleax
Copy link
Member

It’s kind of worrying that a test as simple as this can fail … and once again, it might be nice to get a core dump if that’s possible – @nodejs/build ?

@Trott Trott removed the windows Issues and PRs related to the Windows platform. label Jul 29, 2017
@refack
Copy link
Contributor

refack commented Jul 29, 2017

/cc @aqrln @danbev

@aqrln
Copy link
Contributor

aqrln commented Aug 1, 2017

A core dump would be very handy, I couldn't reproduce this locally yet (now I think about leaving the stress test running for a night or so).

@danbev
Copy link
Contributor

danbev commented Aug 1, 2017

Sorry about the late reply. I'm currently on PTO but will be back next week and will take a closer look at this.

@MylesBorins
Copy link
Contributor

This is popping up all over the v8.3.0 release tests

#14594

@tniessen tniessen mentioned this issue Aug 3, 2017
Closed
addaleax added a commit to addaleax/node that referenced this issue Aug 7, 2017
@addaleax
zlib: fix crash when initializing failed
64da7ab 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: nodejs#14178
Ref: nodejs#13098
@addaleax addaleax mentioned this issue Aug 7, 2017
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented Aug 7, 2017 •
edited
Loading

Fix in #14666

This is caused by #13098, which was backported to v6.x-staging in #13201 – @MylesBorins @gibfahn you will probably want to rebase the backport out.

@gibfahn
Copy link
Member

gibfahn commented Aug 7, 2017

@addaleax I think that was already released (55cbe24 is in v6.11.2 - commit log).

So not sure there's anything we can do other than fast-tracking #14666.

@addaleax
Copy link
Member

addaleax commented Aug 7, 2017

Ugh, right. Looked at the wrong PR.

So not sure there's anything we can do other than fast-tracking #14666.

I personally would feel comfortable landing it later today (it’s literally a one-liner) and including it in 8.3.0, but I also don’t really want to rush my own PRs.

@MylesBorins MylesBorins mentioned this issue Aug 8, 2017
Merged
addaleax added a commit that referenced this issue Aug 9, 2017
@addaleax
zlib: fix crash when initializing failed
a813294 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
PR-URL: #14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 12, 2017
@addaleax @MylesBorins
zlib: fix crash when initializing failed
e79c054 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
PR-URL: #14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
aqrln pushed a commit to aqrln/node that referenced this issue Aug 16, 2017
@addaleax @aqrln
zlib: fix crash when initializing failed
38316ff 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: nodejs#14178
Ref: nodejs#13098
PR-URL: nodejs#14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 19, 2017
@addaleax @MylesBorins
zlib: fix crash when initializing failed
5422eb8 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
Backport-PR-URL: #14860
PR-URL: #14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@addaleax @MylesBorins
zlib: fix crash when initializing failed
a1f9929 
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
Backport-PR-URL: #14860
PR-URL: #14666
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

zlib: fix crash when initializing failed addaleax/node
9 participants
@mscdex @refack @danbev @MylesBorins @Trott @addaleax @aqrln @mhdawson @gibfahn