Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: post-snapshot test-cli-node-options timeouts on RasberryPi #14191

Closed
refack opened this issue Jul 12, 2017 · 1 comment · Fixed by #14195
Closed

test: post-snapshot test-cli-node-options timeouts on RasberryPi #14191

refack opened this issue Jul 12, 2017 · 1 comment · Fixed by #14195
Labels
arm Issues and PRs related to the ARM platform. cli Issues and PRs related to the Node.js command line interface. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented Jul 12, 2017

  • Version: 8.1.4
  • Platform: pi1-raspbian-wheezy
  • Subsystem: test,cli

https://ci.nodejs.org/job/node-test-binary-arm/9178/RUN_SUBSET=2,label=pi1-raspbian-wheezy/

not ok 30 parallel/test-cli-node-options
  ---
  duration_ms: 180.249
  severity: fail
  stack: |-
    timeout
  ...
@refack refack added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. cli Issues and PRs related to the Node.js command line interface. test Issues and PRs related to the tests. labels Jul 12, 2017
@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

Anecdotal numbers from my local Windows machine:

c::\code\node>time < nul&D:\bin\dev\node\node9pre.exe D:\code\node\test\parallel\test-cli-node-options.js&time<nul
The current time is: 11:31:13.32
Enter the new time: The current time is: 11:31:17.62
Enter the new time:
D:\code\node>time < nul&D:\bin\dev\node\node9pre-snapshot.exe D:\code\node\test\parallel\test-cli-node-options.js&time<nul
The current time is: 11:31:20.14
Enter the new time: The current time is: 11:31:21.75
Enter the new time:

without snapshot ~4.3s
with snapshot ~1.61s
The expected 200% slowdown (ref #14171 (comment))

@refack refack mentioned this issue Jul 12, 2017
Merged
3 tasks
refack added a commit to refack/node that referenced this issue Sep 4, 2017
@refack
test: split test-cli-node-options
86e7c61 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: nodejs#14195
Fixes: nodejs#14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 5, 2017
@addaleax
test: split test-cli-node-options
80a2562 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: nodejs/node#14195
Fixes: nodejs/node#14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@refack @MylesBorins
test: split test-cli-node-options
5c7731a 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: #14195
Fixes: #14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 11, 2017
@refack @MylesBorins
test: split test-cli-node-options
df1f462 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: #14195
Fixes: #14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@refack @MylesBorins
test: split test-cli-node-options
e3d0ff9 
* partitioning the subprocess groups
* use `-e` instead of module
* reduce maxBuffer

PR-URL: #14195
Fixes: #14191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. cli Issues and PRs related to the Node.js command line interface. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: try to fix test-cli-node-options refack/node
1 participant
@refack