Using express with the new http2 module

[PiniH]

• Version: v9.0.0-pre
• Platform: MacOS
• Subsystem: http2

Testing node's new http2 native module I couldn't get express to serve requests over http2,
Using node master build with --expose-http2 (v9.0.0-pre macOS) flag:

const express = require('express');

const app = express();

app.get('/express', (req, res) => {
  res.send('Hello from express');
});

const server = http2.createSecureServer({
  key,
  cert
}, app);

When requesting /express the server crashed with the following error:

(node:80731) ExperimentalWarning: The http2 module is an experimental API.
_http_incoming.js:104
  if (this.socket.readable)
                 ^

TypeError: Cannot read property 'readable' of undefined
    at IncomingMessage._read (_http_incoming.js:104:18)
    at IncomingMessage.Readable.read (_stream_readable.js:431:10)
    at IncomingMessage.read (_http_incoming.js:96:15)
    at resume_ (_stream_readable.js:811:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Opened an issue for express as well: expressjs/express#3388
@benjamingr

[benjamingr]

Ping @jasnell - this is a first time contributor trying http2.

[PiniH]

Playing with it a little more - I got it to work, but I had to expose Http2ServerRequest/Response, I think it might be a good idea to expose it in general in the new http2 module.

[PiniH]

There is a matching PR to express, that I am waiting for go / no go (still needs refactoring etc.) but with it - http2 works including push.

…

On Thu, Aug 31, 2017 at 5:57 AM, MongoExpUser ***@***.***> wrote: So, what is the solution to this problem as of today? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14672 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOq55S76pwgWv4VtE_rB5m5TjXquGeFYks5sdiEugaJpZM4OvuHm> .

-- *Pini Houri* Web Developer Mobile: +972-525402819 Email: pini.h@dynamicyield.com [image: cid:image001.png@01CF4CCD.525CBDD0] <http://www.dynamicyield.com/?utm_source=signature&utm_medium=email&utm_campaign=logo>

[benjamingr]

@PiniH any ETA on when we can expect Express to work with http2?

[PiniH]

Wrote to Douglass on the corresponding express PR will update once I get a word from him. On Thu, Aug 31, 2017 at 10:30 AM +0300, "Benjamin Gruenbaum" <notifications@github.com> wrote: @PiniH any ETA on when we can expect Express to work with Http2? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[benjamingr]

@dougwilson

(unrelated: I have removed excess spacing created by replying via email without altering the content in PiniH's post)

[MongoExpUser]

@PiniH,
Thanks for the updates.

[dougwilson]

Has the change to expose the prototype been released yet?

[jasnell]

Not yet. It has landed tho so it should be soon

[dougwilson]

Nice :) also did anything ever happen with the two items at #14690 (comment) ?