Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.allocUnsafeSlow() allowed version in document is incorrect, actually is v5.12.0 #15279

Closed
flarestart opened this issue Sep 8, 2017 · 1 comment
Closed

Buffer.allocUnsafeSlow() allowed version in document is incorrect, actually is v5.12.0 #15279

flarestart opened this issue Sep 8, 2017 · 1 comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Comments

@flarestart
Copy link

  • Version: v6.2.0+
  • Platform: N/A
  • Subsystem: buffer, document

Buffer.allocUnsafeSlow() was added in v5.12.0

Source Code:

https://github.com/nodejs/node/blob/v5.10.0/lib/buffer.js
https://github.com/nodejs/node/blob/v5.12.0/lib/buffer.js line 160

In Documents

https://nodejs.org/dist/v6.2.0/docs/api/buffer.html#buffer_class_method_buffer_allocunsafeslow_size
...
https://nodejs.org/api/buffer.html#buffer_class_method_buffer_allocunsafeslow_size
@mscdex mscdex added doc Issues and PRs related to the documentations. buffer Issues and PRs related to the buffer subsystem. labels Sep 8, 2017
@joyeecheung joyeecheung added the good first issue Issues that are suitable for first-time contributors. label Sep 10, 2017
@joyeecheung
Copy link
Member

Yes, it was added in 5.12.0: 6a94383

I have labeled this as a good first contribution. Whoever wants to pick this one up can fix this by modifying the YAML section in doc/api/buffer.md

@tuananh tuananh mentioned this issue Sep 11, 2017
Closed
4 tasks
jwgoh added a commit to jwgoh/node that referenced this issue Sep 13, 2017
@jwgoh
doc: fix incorrect api version for Buffer.allocUnsafeSlow
10117aa 
Fixes: nodejs#15279
@jwgoh jwgoh mentioned this issue Sep 13, 2017
Closed
4 tasks
@vsemozhetbyt vsemozhetbyt removed the good first issue Issues that are suitable for first-time contributors. label Sep 13, 2017
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 17, 2017
@tuananh @addaleax
doc: fix "added in" for Buffer.allocUnsafeSlow()
2d2c5d6 
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this issue Sep 20, 2017
@tuananh @jasnell
doc: fix "added in" for Buffer.allocUnsafeSlow()
b0f5b2a 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@tuananh
doc: fix "added in" for Buffer.allocUnsafeSlow()
e8e1d8f 
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 17, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
bf13007 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
0b2d548 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix incorrect api version for Buffer.allocUnsafeSlow jwgoh/node
4 participants
@mscdex @joyeecheung @flarestart @vsemozhetbyt