Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, stream: readable._destroy() description is missing in the stream.md #15291

Closed
vsemozhetbyt opened this issue Sep 9, 2017 · 2 comments
Closed

doc, stream: readable._destroy() description is missing in the stream.md #15291

vsemozhetbyt opened this issue Sep 9, 2017 · 2 comments
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 9, 2017 •
edited
Loading

  • Subsystem: doc, stream

There is a link to readable._destroy() in the stream.md after 330c8d7, but there is no readable._destroy() description in the Implementing a Readable Stream part.

cc @mcollina
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 9, 2017
@mcollina
Copy link
Member

Definitely, I'll get this added asap. This is a also a first good contribution, if someone wants to take it.

The content for writable._destroy()  needs to be copied over to readable._destroy(). It's the same logic.

@mcollina mcollina added the good first issue Issues that are suitable for first-time contributors. label Sep 10, 2017
@vsemozhetbyt vsemozhetbyt mentioned this issue Sep 10, 2017
Closed
2 tasks
@vsemozhetbyt
Copy link
Contributor Author

Refs: #15316

@vsemozhetbyt vsemozhetbyt mentioned this issue Sep 10, 2017
Closed
@targos targos removed the good first issue Issues that are suitable for first-time contributors. label Sep 10, 2017
targos added a commit to targos/node that referenced this issue Sep 10, 2017
@targos
doc: add missing doc for readable._destroy
6d9d899 
Fixes: nodejs#15291
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 17, 2017
@targos @addaleax
doc: add missing doc for readable._destroy
b2624f5 
PR-URL: nodejs/node#15316
Fixes: nodejs/node#15291
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this issue Sep 20, 2017
@targos @jasnell
doc: add missing doc for readable._destroy
29707af 
PR-URL: #15316
Fixes: #15291
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@targos
doc: add missing doc for readable._destroy
a6adce9 
PR-URL: nodejs/node#15316
Fixes: nodejs/node#15291
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @targos @vsemozhetbyt