Investigate flaky test-http2-server-rst-stream

[Trott]

• Version: v10.0.0-pre
• Platform: win2008r2-vs2017
• Subsystem: test, http2

https://ci.nodejs.org/job/node-test-binary-windows/12447/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console:

not ok 241 parallel/test-http2-server-rst-stream
  ---
  duration_ms: 0.398
  severity: fail
  stack: |-
    (node:7084) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: rstWithRefuse is not match rstCode
        at ClientHttp2Stream.req.on.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-http2-server-rst-stream.js:55:14)
        at ClientHttp2Stream.<anonymous> (c:\workspace\node-test-binary-windows\test\common\index.js:522:15)
        at emitOne (events.js:130:20)
        at ClientHttp2Stream.emit (events.js:221:7)
        at emit (internal/http2/core.js:140:8)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)

@nodejs/http2 @nodejs/testing @nodejs/platform-windows @nodejs/build

[apapirovski]

Yeah, I think this test just makes too many assumptions about the flow. I've had it on my list for a while. I believe it also fails on node-chakracore and they marked it as flaky.

Will work on it shortly so assigning to myself.

[mhdawson]

Failed here as well https://ci.nodejs.org/job/node-test-binary-windows/12461/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/consoleText

[tniessen]

I believe I saw this failing locally as well.