Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky http2-settings-flood #18251

Closed
BridgeAR opened this issue Jan 19, 2018 · 3 comments
Closed

Flaky http2-settings-flood #18251

BridgeAR opened this issue Jan 19, 2018 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. windows Issues and PRs related to the Windows platform.

Comments

@BridgeAR
Copy link
Member

Multiple timeouts on this test:

https://ci.nodejs.org/job/node-test-commit-freebsd/14756/nodes=freebsd10-64/console
https://ci.nodejs.org/job/node-test-commit-freebsd/14746/nodes=freebsd10-64/console

not ok 2035 sequential/test-http2-settings-flood
  ---
  duration_ms: 120.105
  severity: fail
  stack: |-
    timeout
@BridgeAR BridgeAR added freebsd Issues and PRs related to the FreeBSD platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jan 19, 2018
@jasnell
Copy link
Member

jasnell commented Jan 19, 2018

hmm... yeah, it's a limitation on the ability of the test to trigger the actual error condition being tested for. Basically, in most cases the test actually should fail because the failure condition is supposed to be avoided by the nature of the how the code is implemented. The test is attempting to test an edge case that is inherently flaky and very operating system dependent. We have the same issue with http2-ping-flood. I've been trying to come up with a more reliable alternative approach but haven't been able to find one.

@sethbrenith sethbrenith mentioned this issue Jan 24, 2018
Closed
3 tasks
@Trott Trott added the windows Issues and PRs related to the Windows platform. label Mar 14, 2018
@Trott
Copy link
Member

Trott commented Mar 14, 2018

Definitely happens on Windows too, more frequently than FreeBSD. (It's marked flaky on Windows.)

https://ci.nodejs.org/job/node-test-binary-windows/15672/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=1/console

not ok 529 sequential/test-http2-settings-flood # TODO : Fix flaky test
  ---
  duration_ms: 120.185
  severity: fail
  stack: |-
    timeout

@Trott
Copy link
Member

Trott commented Mar 14, 2018

Hopeful fix. We'll see. #19349

Trott added a commit to Trott/io.js that referenced this issue Mar 15, 2018
@Trott
test: fix flaky test-http2-settings-flood
6dec0e1 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: nodejs#18251
@Trott Trott closed this as completed in 879f521 Mar 16, 2018
targos pushed a commit that referenced this issue Mar 17, 2018
@Trott @targos
test: fix flaky test-http2-settings-flood
425c589 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
@Trott @MylesBorins
test: fix flaky test-http2-settings-flood
739caeb 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
@Trott @MylesBorins
test: fix flaky test-http2-settings-flood
01749f0 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
codebytere pushed a commit that referenced this issue Oct 18, 2018
@Trott @codebytere
test: fix flaky test-http2-settings-flood
b407060 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@mcollina mcollina mentioned this issue Dec 14, 2018
Closed
This was referenced Apr 6, 2024
Open
Open
Open
Open
Open
Open
Open
@wedataintelligence wedataintelligence mentioned this issue Apr 6, 2024
Open
@aliscco aliscco mentioned this issue Apr 6, 2024
Open
This was referenced Apr 6, 2024
Open
Open
@aliscco aliscco mentioned this issue Apr 6, 2024
Open
This was referenced Apr 7, 2024
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@baby636 baby636 mentioned this issue Apr 7, 2024
Open
@ryan-ally ryan-ally mentioned this issue Apr 7, 2024
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@aliscco aliscco mentioned this issue Apr 7, 2024
Open
@leonardoadame leonardoadame mentioned this issue Apr 7, 2024
Open
This was referenced Apr 8, 2024
Open
Open
Open
@wedataintelligence wedataintelligence mentioned this issue Oct 9, 2024
Open
@ron-a20 ron-a20 mentioned this issue Oct 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this issue Oct 11, 2024
Open
This was referenced Oct 21, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnell @Trott @BridgeAR