Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/parallel/test-sync-io-option.js seems to be failing occasionally #1837

Closed
evanlucas opened this issue May 29, 2015 · 1 comment
Closed

test/parallel/test-sync-io-option.js seems to be failing occasionally #1837

evanlucas opened this issue May 29, 2015 · 1 comment
Labels
test Issues and PRs related to the tests.

Comments

@evanlucas
Copy link
Contributor

These are the two assertions I am getting:

assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: 1 == 2
    at ChildProcess.<anonymous> (/Users/evan/dev/code/forks/io.js/test/parallel/test-sync-io-option.js:33:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (child_process.js:1009:12)

assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: 0 == 2
    at ChildProcess.<anonymous> (/Users/evan/dev/code/forks/io.js/test/parallel/test-sync-io-option.js:33:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (child_process.js:1009:12)
@mscdex mscdex added the test Issues and PRs related to the tests. label May 29, 2015
This was referenced May 29, 2015
Merged
Merged
evanlucas added a commit to evanlucas/node that referenced this issue Jun 3, 2015
@evanlucas
test: fix test-sync-io-option
43a82f8 
This test was failing occasionally both locally and on CI. Switched
from using spawn to execFile for a more reliable test.

Fixes: nodejs#1837
PR-URL: nodejs#1840
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@trevnorris
Copy link
Contributor

Fixed by 43a82f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @trevnorris @evanlucas