Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node --prof-process is broken #18451

Closed
hashseed opened this issue Jan 30, 2018 · 0 comments
Closed

node --prof-process is broken #18451

hashseed opened this issue Jan 30, 2018 · 0 comments
Labels
tools Issues and PRs related to the tools directory.

Comments

@hashseed
Copy link
Member

Repro:

git checkout 742ae6141c164a90442c363599ea0356ed250570
./configure
make -j100 node
./node --prof -e "for(var i=0;i<1E7;i++);"
./node --prof-process isolate*.log

Observation:

undefined:3402
class ArgumentsProcessor extends BaseArgumentsProcessor {
                                 ^

ReferenceError: BaseArgumentsProcessor is not defined
    at eval (eval at <anonymous> (internal/v8_prof_processor.js:38:1), <anonymous>:3402:34)
    at eval (eval at <anonymous> (internal/v8_prof_processor.js:38:1), <anonymous>:3947:3)
    at internal/v8_prof_processor.js:38:1
    at NativeModule.compile (bootstrap_node.js:626:7)
    at Function.NativeModule.require (bootstrap_node.js:558:18)
    at startup (bootstrap_node.js:140:20)
    at bootstrap_node.js:638:3
@hashseed hashseed added the tools Issues and PRs related to the tools directory. label Jan 30, 2018
@jasnell jasnell closed this as completed in 42258d7 Feb 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
This commit includes deps/v8/tools/arguments.js, which is
needed by the profiler.

PR-URL: nodejs#18455
Fixes: nodejs#18451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

1 participant