npm: SSL error on v2.2.0

[targos]

Attempting to install a module with npm fails with the following error:
SSL Error: https://registry.npmjs.org/test does not support SSL.

Reproduced on Windows 8.1 x64 and Windows 10 x64.

The error only happens for modules that were never installed on the machine. My guess is that npm uses the local cache for known modules.

C:\Users\Michael\test>iojs -v
v2.2.0

C:\Users\Michael\test>npm -v
2.11.0

C:\Users\Michael\test>npm install abc
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\iojs\\node.exe" "C:\\Program Files\\iojs\\node
_modules\\npm\\bin\\npm-cli.js" "install" "abc"
npm ERR! node v2.2.0
npm ERR! npm  v2.11.0
npm ERR! code ESSL

npm ERR! SSL Error: https://registry.npmjs.org/abc does not support SSL
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Michael\test\npm-debug.log

C:\Users\Michael\test2>iojs -v
v2.1.0

C:\Users\Michael\test2>npm -v
2.10.1

C:\Users\Michael\test2>npm install abc
abc@0.6.1 node_modules\abc

[targos]

Error is generated by the request module, here: https://github.com/request/request/blob/04bcd915dff978bd4874faafdf5567abe9230636/request.js#L1067

[campersau]

+1 this also breaks my io.js tests on travis https://travis-ci.org/FredrikNoren/ungit/jobs/64777573

[rvagg]

this seems to be impacting Linux as well, OSX appears to be fine

ping @othiym23, @iama

[targos]

1eec5f0

[targos]

this broke the response.hasOwnProperty('client') check from request

[rvagg]

reversion @ #1851, see comments there, sorry for pulling you in @othiym23 & @iama (I meant that to be @-iarna, so sorry whoever you are).

[targos]

there was no CI run for #1829 :(

[rvagg]

probably wouldn't have helped, we're still shaving the test-npm yak, /cc @fishrosk123

[targos]

/cc @Fishrock123

[vitaly-t]

+1, broke my IO.js tests on Travis CI.

[wzrdtales]

+1, my tests on travis with io.js are also broken

[Globegitter]

@rvagg Just installed iojs 2.2.0 on mac osx and the same bug is affecting me.

[seemsindie]

+1 Same error here on arch linux

[nshtg]

Jep, breaks on a fresh installed server with debian 8. How can something like this slip into production?!

[Fishrock123]

This is probably my fault, I think I forgot to run the test-npm for #1829. Investigating.

How can something like this slip into production?!

We still can't run test-npm from the CI well.

[chrisdickinson]

Request's response.hasOwnProperty('client') check does not see it because it is a getter/setter.

A {g,s}etter would have been okay – the problem is that the property was set on the prototype instead of the instance.

[Fishrock123]

A {g,s}etter would have been okay – the problem is that the property was set on the prototype instead of the instance.

Yes, I think we should do a static analysis and reconsider deprecating in the future.

[dougwilson]

It's amusing to see so many people's tests failing on Travis CI because of this issue, mainly because many, many module are only specifying iojs for nvm to install, which is simply asking for a lot of pain.

[capaj]

@dougwilson still lesser pain than to update travis.yml manually with each new io.js release. I for one will not bother to specify an io.js version in my travis.yml, because I think that this situation will not repeat again.

[silverwind]

2.2.1 is out, fixing this. Get it while it's hot!

[sbrl]

How can I update npm if when I run npm update npm -g --force it fails because of this bug?

[ljharb]

@sbrl you need to update io.js itself to v2.2.1 - you can't fix it with npm. also npm install -g npm@latest to update npm.

[sbrl]

@ljharb Thanks, that fixed it :)