Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete link and maybe info in crypto.md #18662

Closed
vsemozhetbyt opened this issue Feb 8, 2018 · 1 comment
Closed

Obsolete link and maybe info in crypto.md #18662

vsemozhetbyt opened this issue Feb 8, 2018 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 8, 2018 •
edited
Loading

See intro notes for Certificate class: https://github.com/nodejs/node/blob/master/doc/api/crypto.md#class-certificate

The link is 404 now: https://www.w3.org/TR/html5/forms.html#the-keygen-element

Last working link time: https://web.archive.org/web/20171207004547/https://www.w3.org/TR/html5/forms.html#the-keygen-element

No <keygen> part in the new spec: https://www.w3.org/TR/html5/sec-forms.html

The cause: https://www.w3.org/TR/html52/changes.html#features-removed

It seems we should change the link at least and maybe add a note about element removal from the spec.

cc @nodejs/crypto
@vsemozhetbyt vsemozhetbyt added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 8, 2018
@antoine-amara
Copy link
Contributor

I update the documentation, I will post a PR very soon.

@antoine-amara antoine-amara mentioned this issue Feb 11, 2018
Closed
4 tasks
antoine-amara added a commit to antoine-amara/node that referenced this issue Feb 14, 2018
@antoine-amara
doc: update crypo Certficate class.
59379d3 
update the dead link to <keygen> documentation.
add a link to mozilla developper documentation because
W3C delete the reference to this element.

add a note to inform <keygen> element is deprecated since HTML 5.2.

Fixes: nodejs#18662
@priyank-p priyank-p mentioned this issue Feb 16, 2018
Merged
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
67c1811 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
9bec493 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@antoine-amara @MayaLekova
doc: update crypo Certficate class.
fcd6cb5 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: nodejs#18721
Fixes: nodejs#18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
b01e470 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
824fb0e 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 9, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
48ab389 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 16, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
9c52231 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update crypo Certficate class. antoine-amara/node
2 participants
@vsemozhetbyt @antoine-amara