Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky parallel/test-fs-error-messages #18820

Closed
BridgeAR opened this issue Feb 16, 2018 · 1 comment
Closed

Flaky parallel/test-fs-error-messages #18820

BridgeAR opened this issue Feb 16, 2018 · 1 comment
Assignees
@joyeecheung
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Comments

@BridgeAR
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-linux/16242/nodes=alpine36-container-x64/console

not ok 465 parallel/test-fs-error-messages
  ---
  duration_ms: 0.293
  severity: fail
  stack: |-
    /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/test/parallel/test-fs-error-messages.js:90
        assert.strictEqual(err.message, 'EBADF: bad file descriptor, fstat');
                               ^
    
    TypeError: Cannot read property 'message' of null
        at validateError (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/test/parallel/test-fs-error-messages.js:90:28)
        at /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/test/common/index.js:475:15
        at FSReqWrap.oncomplete (fs.js:285:5)
@BridgeAR BridgeAR added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 16, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Feb 17, 2018 •
edited
Loading

This could be caused by a race condition of the invalid fd generation...I could think of an alternative way of getting those (e.g. starting from 1 << 30 and counting down, usually that should be invalid from the start).

@joyeecheung joyeecheung self-assigned this Feb 17, 2018
@joyeecheung joyeecheung mentioned this issue Feb 19, 2018
Closed
3 tasks
joyeecheung added a commit that referenced this issue Feb 22, 2018
@joyeecheung
test: use runWithInvalidFD() in tests expecting EBADF
5055c29 
PR-URL: #18864
Fixes: #18820
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@joyeecheung @MayaLekova
test: introduce common.runWithInvalidFD()
61620a1 
This provides a more reliable way to get a fd that can be used
to tirgger EBADF.

PR-URL: nodejs#18864
Fixes: nodejs#18820
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@joyeecheung @MayaLekova
test: use runWithInvalidFD() in tests expecting EBADF
fbd0b59 
PR-URL: nodejs#18864
Fixes: nodejs#18820
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joyeecheung joyeecheung

Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joyeecheung @BridgeAR