Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage broken #18938

Closed
BridgeAR opened this issue Feb 22, 2018 · 4 comments
Closed

Coverage broken #18938

BridgeAR opened this issue Feb 22, 2018 · 4 comments
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.

Comments

@BridgeAR
Copy link
Member

https://coverage.nodejs.org/ displays nothing new since nine days. I feel something has gone wrong here?

/cc @mhdawson

@BridgeAR BridgeAR added the build Issues and PRs related to build files or the CI. label Feb 22, 2018
@targos
Copy link
Member

targos commented Feb 22, 2018

Last run: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage/542/

if [ ! -f gcovr/scripts/gcovr.orig ]; then \
		(cd gcovr && patch -N -p1 < \
		"/home/iojs/build/workspace/node-test-commit-linux-coverage/nodes/benchmark/build/jenkins/scripts/coverage/gcovr-patches.diff"); fi
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/scripts/gcovr b/scripts/gcovr
|index 034779c86d29..e68b239c424f 100755
|--- a/scripts/gcovr
|+++ b/scripts/gcovr
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
2 out of 2 hunks ignored
make: *** [coverage-build] Error 1
Build step 'Execute shell' marked build as failure

The gcovr script moved: gcovr/gcovr@27756c8

@BridgeAR BridgeAR added the confirmed-bug Issues with confirmed bugs. label Feb 22, 2018
@killagu
Copy link
Contributor

killagu commented Feb 22, 2018

Update gcovr-patches.diff can fix it,I will raise a PR in nodejs/build to fix it.
Makefile should be updated too.

killagu added a commit to killagu/build that referenced this issue Feb 23, 2018
killagu added a commit to killagu/node that referenced this issue Feb 23, 2018
mhdawson pushed a commit to nodejs/build that referenced this issue Feb 28, 2018
PR-URL: #1145
Ref: nodejs/node#18938
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: MichaëZasso <targos@protonmail.com>
@trivikr
Copy link
Member

trivikr commented Feb 28, 2018

FYI https://coverage.nodejs.org/ doesn't show any past coverages now.

@BridgeAR
Copy link
Member Author

Nice that this got fixed. @mhdawson would you please have a look at the concrete coverage output from today e.g. https://coverage.nodejs.org/coverage-ee34d7e54ae39766/index.html? Is this going to be fixed with the next regular coverage run?

addaleax pushed a commit to addaleax/node that referenced this issue Mar 5, 2018
PR-URL: nodejs#18958
Fixes: nodejs#18938
Ref: nodejs/build#1145
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
PR-URL: nodejs#18958
Fixes: nodejs#18938
Ref: nodejs/build#1145
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants