Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposing SSL_get_finished and SSL_get_peer_finished #19055

Closed
codedot opened this issue Feb 28, 2018 · 2 comments
Closed

exposing SSL_get_finished and SSL_get_peer_finished #19055

codedot opened this issue Feb 28, 2018 · 2 comments
Labels
feature request Issues that request new features to be added to Node.js. tls Issues and PRs related to the tls subsystem.

Comments

@codedot
Copy link
Contributor

codedot commented Feb 28, 2018 •
edited
Loading

  • Subsystem: tls (tls.TLSSocket)

This is a feature request to expose OpenSSL routines SSL_get_finished and SSL_get_peer_finished as tls.TLSSocket.getFinished() and tls.TLSSocket.getPeerFinished(), respectively. They are required to implement the current version of rippled peer protocol; see XRPLF/rippled#2413 for details.
@watilde watilde added the tls Issues and PRs related to the tls subsystem. label Feb 28, 2018
@addaleax
Copy link
Member

How does the peer provide the messages that would be returned by these functions using the OpenSSL API?

@codedot
Copy link
Contributor Author

codedot commented Feb 28, 2018

The exact way the SSL_get_finished and SSL_get_peer_finished routines are used in rippled can be found in the src/ripple/overlay/impl/TMHello.cpp module, lines 31-93. I think that exposing them in Node.js can be done similarly to how SSL_get_session routine is exposed as tls.TLSSocket.getSession() in the src/node_crypto.cc module, lines 2100-2118.

@codedot codedot mentioned this issue Mar 3, 2018
Closed
4 tasks
@addaleax addaleax added the feature request Issues that request new features to be added to Node.js. label Mar 11, 2018
targos pushed a commit that referenced this issue Mar 17, 2018
@codedot @targos
tls: expose Finished messages in TLSSocket
e976dc1 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
0602166 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@codedot @MayaLekova
tls: expose Finished messages in TLSSocket
43c8082 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: nodejs#19102
Fixes: nodejs#19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
bcaba81 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
525b338 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
a1dd1fa 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 9, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
f4e8bf5 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 16, 2018
@codedot @MylesBorins
tls: expose Finished messages in TLSSocket
1f49de4 
Exposes SSL_get_finished and SSL_get_peer_finished routines in OpenSSL
as tlsSocket.getFinished and tlsSocket.getPeerFinished, respectively.

PR-URL: #19102
Fixes: #19055
Refs: XRPLF/rippled#2413
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tls: expose Finished messages in TLSSocket
3 participants
@codedot @addaleax @watilde