Error while running coverage

[trivikr]

• Version: master
• Platform: macOS Sierra Version 10.12.6
• Subsystem: N/A
• Xcode: Version 9.2 (9C40b)

I tried to run coverage by following the instructions given in https://github.com/nodejs/node/blob/master/BUILDING.md#building-nodejs-1

The following commands were run:

$ ./configure --coverage
$ make coverage

Coverage failed with the following error:

error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `-' in: --coverage
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
make[1]: *** [/Users/trivikr/workspace/node/out/Release/libnode.a] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [node] Error 2

Is anyone else facing the same issue?

[evanlucas]

I can reproduce on High Sierra. Bisecting now

[killagu]

It's failed on my mac too. Apple's libtool is not support --coverage.

When I try to fix the coverage bug, I just use the CentOS.

@trivikr Can you try the glibtool?

[jvelezpo]

I can reproduce this on High Sierra.

And I dont know if i should create a new issue, but i found that make doc throws a similar error

error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `-' in: --coverage
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
make[1]: *** [/Users/sebastian/Desktop/TEMP/node/out/Release/libnode.a] Error 1
rm 11dfd781c7c2539ee10fb0ab5ee933e2636fb641.intermediate
make: *** [node] Error 2

[trivikr]

@jvelezpo Looks like it's the same error, so new issue is not required.
unknown option character `-' in: --coverage

[nigelhanlon]

I am having the same issue when running make coverage.

• Version: master
• Platform: macOS High Sierra Version 10.13.3.
• Subsystem: N/A
• Xcode: Version 9.2 (9C40b)

hello.o /Users/nigelhanlon/Source/node/node/out/Release/obj.target/node_lib/src/tls_wrap.o
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `-' in: --coverage
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
make[1]: *** [/Users/nigelhanlon/Source/node/node/out/Release/libnode.a] Error 1
rm 7080b3e45e89e1cd86c4d606e0421ef4647f1b29.intermediate
make: *** [node] Error 2

[boneskull]

Did this ever work?

Using glibtool introduces other errors (like no support for -static)

[mhdawson]

@boneskull I seem to remember a PR that made coverage work on OSX but I never checked it out myself.

[evanlucas]

This did use to work. (I submitted the PR). I haven't been able to figure out why it no longer works though. I may be able to dig into it again in the next few days

[boneskull]

@evanlucas Were you able to make any progress here? I'm not sure how I'd figure it out short of just bisecting. If you don't have time to look into it yourself, I was wondering if you had any hints? 😉

[evanlucas]

@boneskull nah I haven't been able to make any progress on it. I'd bet it has to do with changes to something that gets pulled in during make coverage, so I'd start by looking if anything gets cloned from that step. I vaguely remember something like that.