-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add documentation on porting from Buffer(arg) usage #19827
Comments
I think the best place is a medium blog post or a guide https://nodejs.org/en/docs/guides. Or both. |
The deprecation of the |
/ping @nodejs/tsc |
This is on the TSC agenda for this week, but it's not clear to me what the TSC needs to actually decide. Can we get a brief explanation of what is needed from the TSC on this? @ChALkeR |
@nodejs/buffer |
ping @ChALkeR Is there anything we need to discuss? Or is it just FYI on the tsc agenda? |
I created a pull request with some improvements, but nothing that changes the actual meaning of any text significantly. ChALkeR/safer-buffer#5 @fhinkel In the TSC meeting, we agreed to give this doc editing until today and then hand it off to...you, was it? I obviously did not get to go over this as thoroughly as I had hoped, but if someone else has more time and/or energy, great! If we can publish it somewhere that others can continue to edit and improve it, then I think it's ship-able. (I'm almost sorry that we don't have the nodejs repo wiki anymore.) |
Thanks @Trott, I'm on it right now 😺 |
Add guide from https://github.com/ChALkeR/safer-buffer/blob/master/Porting-Buffer.md Original authors: @ChALkeR @addaleax @Trott Fixes: nodejs/node#19827 Refs: nodejs/node#19079
Hey, should this issue actually be closed or stay open? It was just weird that a commit from the wrong repo closed it. |
Closed. |
Refs: #19079
As previously discussed, it would be great if we could provide that instructions somewhere (docs, news, medium, whatever).
I made an initial draft in my repo here: Porting-Buffer.md, and @addaleax contributed significant parts of it.
What would be the next steps to discuss it and fix it so that it could be included somewhere?
I guess that needs to be done in time for 10.0 release.
Also: comments/patches to the doc at its current state are welcomed.
/cc @nodejs/tsc
The text was updated successfully, but these errors were encountered: