Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: process event uncaughtException pointing to deprecated module #2055

Closed
albertorestifo opened this issue Jun 25, 2015 · 4 comments
Closed

Documentation: process event uncaughtException pointing to deprecated module #2055

albertorestifo opened this issue Jun 25, 2015 · 4 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@albertorestifo
Copy link

On the Process event 'uncaughtException' documentation, you are pointed to use domains instead for exception handling.

Given that the domain module is pending deprecation, an alternative solution should be documented.
@benjamingr
Copy link
Member

Yes, definitely. I think even leaving the error in place without a solution is a good idea.

@benjamingr benjamingr mentioned this issue Jun 25, 2015
Closed
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jun 25, 2015
@wonderdogone
Copy link

wouldn't one want to process.exit gracefully

benjamingr added a commit to benjamingr/io.js that referenced this issue Jul 2, 2015
@benjamingr
Don't recommend domains for error handling
6466a20 
This PR closes nodejs#2055 by removing the suggestion to use domains for exception handling. Additionally clarify `unhandledException` a bit.

PR-URL: nodejs#2056
Reviewed-By: Trev Norris <trev.norris@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
trevnorris pushed a commit that referenced this issue Jul 3, 2015
@benjamingr @trevnorris
doc: don't recommend domains for error handling
0f09b8d 
Remove the suggestion to use domains for exception handling. Add clarity
to "unhandledException".

Fixes: #2055
PR-URL: #2056
Reviewed-By: Trev Norris <trev.norris@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
@trevnorris
Copy link
Contributor

Fixed by 0f09b8d.

@benjamingr
Copy link
Member

Thanks :)

mscdex pushed a commit to mscdex/io.js that referenced this issue Jul 9, 2015
@benjamingr @mscdex
doc: don't recommend domains for error handling
991cfe9 
Remove the suggestion to use domains for exception handling. Add clarity
to "unhandledException".

Fixes: nodejs#2055
PR-URL: nodejs#2056
Reviewed-By: Trev Norris <trev.norris@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
@aliscco aliscco mentioned this issue Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't recommend domains for error handling benjamingr/io.js
5 participants
@mscdex @trevnorris @wonderdogone @albertorestifo @benjamingr