Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There may be a syntax error in the nodejs napi doc. #21049

Closed
caijw opened this issue May 31, 2018 · 3 comments
Closed

There may be a syntax error in the nodejs napi doc. #21049

caijw opened this issue May 31, 2018 · 3 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. node-api Issues and PRs related to the Node-API.

Comments

@caijw
Copy link

caijw commented May 31, 2018

  • Version: nodejs 10.3.0 documents
  • Platform:
  • Subsystem:

https://nodejs.org/dist/latest-v10.x/docs/api/n-api.html#n_api_object_lifetime_management

This document may has a syntax error:

In many cases, however, it is necessary that the handles remain valid for either a shorter or longer lifespan than that of the native method. The sections which follow describe the N-API functions than can be used to change the handle lifespan from the default.

...the N-API functions than can be used to change the..., than shoul change to that.
@Trott
Copy link
Member

Trott commented May 31, 2018

@nodejs/n-api

@Trott Trott added node-api Issues and PRs related to the Node-API. doc Issues and PRs related to the documentations. labels May 31, 2018
@vsemozhetbyt vsemozhetbyt added the good first issue Issues that are suitable for first-time contributors. label May 31, 2018
@ryzokuken
Copy link
Contributor

@caijw It's not a syntax error, but a grammatical one. Feel free to publish a patch for this.

@ohbarye
Copy link
Contributor

ohbarye commented May 31, 2018

May I address this issue?

ohbarye added a commit to ohbarye/node that referenced this issue May 31, 2018
@ohbarye
doc: fix typo in n-api.md
3b3d1e7 
just replaced `than` with `that`.

- wrong: the N-API functions than can be used to change
- correct: the N-API functions that can be used to change

Fixes: nodejs#21049
@ohbarye ohbarye mentioned this issue May 31, 2018
Closed
3 tasks
@Trott Trott closed this as completed in dcecfb7 May 31, 2018
addaleax pushed a commit that referenced this issue Jun 1, 2018
@ohbarye @addaleax
doc: fix typo in n-api.md
4012e05 
just replaced `than` with `that`.

- wrong: the N-API functions than can be used to change
- correct: the N-API functions that can be used to change

Fixes: #21049

PR-URL: #21060
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix typo in n-api.md ohbarye/node
5 participants
@Trott @ohbarye @vsemozhetbyt @caijw @ryzokuken