Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing cli options #21230

Closed
vsemozhetbyt opened this issue Jun 9, 2018 · 5 comments
Closed

doc: missing cli options #21230

vsemozhetbyt opened this issue Jun 9, 2018 · 5 comments
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. worker Issues and PRs related to Worker support.

Comments

@vsemozhetbyt
Copy link
Contributor

In the last CLI doc, these options are missing:

--experimental-worker
--loader

But they are present in the source whitelist for NODE_OPTIONS:

node/src/node.cc

Lines 3162 to 3168 in 2237a8e

"--experimental-worker",
"--force-fips",
"--icu-data-dir",
"--inspect",
"--inspect-brk",
"--inspect-port",
"--loader",

cc @addaleax @nodejs/modules, as I am not sure how to document them.
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. cli Issues and PRs related to the Node.js command line interface. worker Issues and PRs related to Worker support. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jun 9, 2018
@ljharb
Copy link
Member

ljharb commented Jun 9, 2018

Both are experimental; should they be documented at this point?

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jun 9, 2018 •
edited
Loading

@ljharb --loader is already documented in esm.html, and without --experimental-worker examples in the worker_threads.html do not work.

@ryzokuken
Copy link
Contributor

@vsemozhetbyt let's just tag this as good-first-issue?

@vsemozhetbyt
Copy link
Contributor Author

Why not if anybody is sure how to document this)

@vsemozhetbyt
Copy link
Contributor Author

--experimental-worker will be documented in #21461

@SirR4T SirR4T mentioned this issue Aug 3, 2018
Closed
3 tasks
targos pushed a commit that referenced this issue Aug 19, 2018
@SirR4T @targos
doc: add doc for --loader option
c76fb12 
PR-URL: #22104
Fixes: #21230
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
targos pushed a commit that referenced this issue Sep 3, 2018
@SirR4T @targos
doc: add doc for --loader option
e644088 
PR-URL: #22104
Fixes: #21230
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
@snyk-bot snyk-bot mentioned this issue Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add doc for --loader option SirR4T/node
3 participants
@ljharb @vsemozhetbyt @ryzokuken