Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-fs-readfilesync-enoent failing locally with unknown error #21501

Closed
targos opened this issue Jun 24, 2018 · 3 comments
Closed

test-fs-readfilesync-enoent failing locally with unknown error #21501

targos opened this issue Jun 24, 2018 · 3 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Jun 24, 2018

  • Version: master, v10.5.0
  • Platform: Windows 10 x64
  • Subsystem: fs
PS D:\Documents\GitHub\nodejs\node> node D:\Documents\GitHub\nodejs\node\test\parallel\test-fs-readfilesync-enoent.js
fs.js:119
    throw err;
    ^

Error: UNKNOWN: unknown error, lstat '\\localhost\c$\'
    at Object.realpathSync (fs.js:1395:5)
    at test (D:\Documents\GitHub\nodejs\node\test\parallel\test-fs-readfilesync-enoent.js:17:21)
    at Object.<anonymous> (D:\Documents\GitHub\nodejs\node\test\parallel\test-fs-readfilesync-enoent.js:26:1)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
    at startup (internal/bootstrap/node.js:240:19)

/cc @nodejs/platform-windows

@targos targos added fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Jun 24, 2018
@bzoz
Copy link
Contributor

bzoz commented Jun 25, 2018

This works on my box. Maybe you have administrative shares disabled?

@targos
Copy link
Member Author

targos commented Jun 25, 2018

@bzoz My C: drives is shared. I found now that the call to fs.realpathSync() succeeds if I replace "localhost" with my computer's name. Would it make sense to modify the test and use os.hostname()?

@bzoz
Copy link
Contributor

bzoz commented Jun 28, 2018

If it makes the test pass on your box then why not. Do you want me to make a PR for this?

lundibundi added a commit to lundibundi/node that referenced this issue Sep 26, 2018
@danbev danbev closed this as completed in 1be804d Oct 1, 2018
targos pushed a commit that referenced this issue Oct 1, 2018
PR-URL: #23101
Fixes: #21501
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
targos pushed a commit that referenced this issue Oct 3, 2018
PR-URL: #23101
Fixes: #21501
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants