Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-tls-server-verify broken by crl in testing fixtures being expired #22182

Closed
MylesBorins opened this issue Aug 7, 2018 · 3 comments
Closed

parallel/test-tls-server-verify broken by crl in testing fixtures being expired #22182

MylesBorins opened this issue Aug 7, 2018 · 3 comments
Labels
test Issues and PRs related to the tests.

Comments

@MylesBorins
Copy link
Contributor

expired about 45 minutes ago.

attempting to rebuild all the pem files right now with the makefile found in the keys directory... will open PR to close this if it works

/cc @bnoordhuis @indutny @nodejs/crypto
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Aug 7, 2018 •
edited
Loading

/cc @nodejs/tsc this is likely breaking all the things everywhere that people are building node

edit: to be more explicit... all test suites for all versions of node are currently broken by this.

@richardlau
Copy link
Member

I think this warrants an FYI for @nodejs/collaborators

@richardlau richardlau added the test Issues and PRs related to the tests. label Aug 7, 2018
@MylesBorins
Copy link
Contributor Author

refs to prior art on this:

#7194
#3759

indutny added a commit that referenced this issue Aug 7, 2018
@indutny
test: update certificates and private keys
111feb2 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.

Fix: #22182
@indutny indutny mentioned this issue Aug 7, 2018
Closed
4 tasks
@MylesBorins MylesBorins mentioned this issue Aug 8, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this issue Aug 8, 2018
@indutny @MylesBorins
test: update certificates and private keys
a6b9ee9 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Aug 8, 2018
@indutny @MylesBorins
test: update certificates and private keys
6efbe1a 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Aug 8, 2018
@indutny @MylesBorins
test: update certificates and private keys
50ccfec 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Aug 8, 2018
@indutny @MylesBorins
test: update certificates and private keys
14b46d0 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Aug 9, 2018
@indutny @MylesBorins
test: update certificates and private keys
0c9760d 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update certificates and private keys nodejs/node
2 participants
@MylesBorins @richardlau