Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: help annotate test/parallel/test-util-log.js #22472

Closed
refack opened this issue Aug 23, 2018 · 1 comment
Closed

test: help annotate test/parallel/test-util-log.js #22472

refack opened this issue Aug 23, 2018 · 1 comment
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented Aug 23, 2018 •
edited
Loading

Help needed with some code archeology:
The test in node/test/parallel/test-util-log.js ends with common.restoreStdout(); but no common.restoreStderr();

node/test/parallel/test-util-log.js

Lines 58 to 60 in 6acb550

assert.strictEqual(process.stdout.writeTimes, tests.length);
common.restoreStdout();

We should have a comment documenting the reason why (or fix it).

Ref: #13439
@refack refack added test Issues and PRs related to the tests. good first issue Issues that are suitable for first-time contributors. labels Aug 23, 2018
@refack refack mentioned this issue Aug 23, 2018
Closed
4 tasks
@abelmark
Copy link
Contributor

Submitted a pull request.

@abelmark abelmark mentioned this issue Aug 24, 2018
Closed
1 task
targos pushed a commit that referenced this issue Sep 20, 2018
@abelmark @targos
lib: added common.restoreStderr(); to end of file
fb68ef2 
Fixes: #22472
Co-authored-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #22487
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test fix
2 participants
@refack @abelmark