Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node::Environment::tracing_agent_writer returns nullptr in a worker #22767

Closed
eugeneo opened this issue Sep 9, 2018 · 1 comment
Closed

node::Environment::tracing_agent_writer returns nullptr in a worker #22767

eugeneo opened this issue Sep 9, 2018 · 1 comment
Labels
inspector Issues and PRs related to the V8 inspector protocol trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. worker Issues and PRs related to Worker support.

Comments

@eugeneo
Copy link
Contributor

eugeneo commented Sep 9, 2018

I found out that this method returns nullptr. I did not investigate further, hoping to do it when I get some time.

CC: @addaleax, @ofrobots
@eugeneo eugeneo added inspector Issues and PRs related to the V8 inspector protocol trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. worker Issues and PRs related to Worker support. labels Sep 9, 2018
@eugeneo
Copy link
Contributor Author

eugeneo commented Sep 9, 2018

Probably the same discussion: #22513

@richardlau richardlau mentioned this issue Oct 16, 2018
Closed
3 tasks
richardlau added a commit to richardlau/node-1 that referenced this issue Oct 16, 2018
@richardlau
squash: skip test-trace-events-api.js for workers
3e9d309 
Refs: nodejs#22767
@addaleax addaleax mentioned this issue Oct 20, 2018
Closed
3 tasks
addaleax added a commit to addaleax/node that referenced this issue Oct 21, 2018
@addaleax
src: remove Environment::tracing_agent_writer()
afef60e 
As per the conversation in nodejs#22513,
this is essentially global, and adding this on the Environment
is generally just confusing.

Refs: nodejs#22513
Fixes: nodejs#22767
mmarchini pushed a commit that referenced this issue Oct 24, 2018
@addaleax @mmarchini
trace_events: forbid tracing modifications from worker threads
5d80ae3 
Forbid modifying tracing state from worker threads, either
through the built-in module or inspector sessions, since
the main thread owns all global state, and at least
the `async_hooks` integration is definitely not thread
safe in its current state.

PR-URL: #23781
Fixes: #22767
Refs: #22513
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit that referenced this issue Oct 27, 2018
@addaleax @targos
src: remove Environment::tracing_agent_writer()
75485ef 
As per the conversation in #22513,
this is essentially global, and adding this on the Environment
is generally just confusing.

Refs: #22513
Fixes: #22767

PR-URL: #23781
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit that referenced this issue Oct 27, 2018
@addaleax @targos
trace_events: forbid tracing modifications from worker threads
bcfeaae 
Forbid modifying tracing state from worker threads, either
through the built-in module or inspector sessions, since
the main thread owns all global state, and at least
the `async_hooks` integration is definitely not thread
safe in its current state.

PR-URL: #23781
Fixes: #22767
Refs: #22513
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit that referenced this issue Nov 18, 2018
@addaleax @targos
src: remove Environment::tracing_agent_writer()
4e8e395 
As per the conversation in #22513,
this is essentially global, and adding this on the Environment
is generally just confusing.

Refs: #22513
Fixes: #22767

PR-URL: #23781
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit that referenced this issue Nov 18, 2018
@addaleax @targos
trace_events: forbid tracing modifications from worker threads
92101a6 
Forbid modifying tracing state from worker threads, either
through the built-in module or inspector sessions, since
the main thread owns all global state, and at least
the `async_hooks` integration is definitely not thread
safe in its current state.

PR-URL: #23781
Fixes: #22767
Refs: #22513
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@addaleax @rvagg
src: remove Environment::tracing_agent_writer()
5061610 
As per the conversation in #22513,
this is essentially global, and adding this on the Environment
is generally just confusing.

Refs: #22513
Fixes: #22767

PR-URL: #23781
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@addaleax @rvagg
trace_events: forbid tracing modifications from worker threads
b6004b3 
Forbid modifying tracing state from worker threads, either
through the built-in module or inspector sessions, since
the main thread owns all global state, and at least
the `async_hooks` integration is definitely not thread
safe in its current state.

PR-URL: #23781
Fixes: #22767
Refs: #22513
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eugeneo