build: windows releases should not include npm tests

[NN---]

Node 10.10 with NPM 6.4.1

Is there any reason why npm has test directory inside ?
It creates a long path for Windows and fails to install:

node_modules\npm\test\npm_cache\content-v2\sha512\76\39\4b378512c68bf209b433e06b71df27a45f7e7be35f174a0f83bce7799628b74dbe993c18b1c12e899a1ed7b159470b382180d1f0a5c4098ac6092cda1a8f

[vsemozhetbyt]

I have the same file from v8-canary install on Windows 7 x64 (the instalation was successful though):
c:\Program Files\nodejs\node_modules\npm\test\npm_cache\content-v2\sha512\76\39\4b378512c68bf209b433e06b71df27a45f7e7be35f174a0f83bce7799628b74dbe993c18b1c12e899a1ed7b159470b382180d1f0a5c4098ac6092cda1a8f

See:
https://github.com/nodejs/node/tree/master/deps/npm/test/npm_cache/content-v2/sha512/76/39
https://github.com/nodejs/node/tree/master/deps/npm/test/npm_cache/_cacache/content-v2/sha512/76/39

cc @nodejs/npm

[targos]

I don't think npm tests are needed to run npm? We could try to remove them from the binary distribution.

[joyeecheung]

Relavent code is here:

node/vcbuild.bat

Line 339 in a7b59d6

robocopy /e ..\deps\npm node-v%FULLVERSION%-win-%target_arch%\node_modules\npm > nul

[joyeecheung]

Hmm, any reason vcbuild.bat does not use tools/install.py? That script does skip the test directory. cc @nodejs/build-files

node/tools/install.py

Line 87 in a7b59d6

subdirs[:] = filter('test'.__ne__, subdirs) # skip test suites

[richardlau]

Well for one thing the install location is different (node_modules\npm on Windows vs lib/node_modules/npm/ via install.py):

node/tools/install.py

Line 78 in a7b59d6

target_path = 'lib/node_modules/npm/'

and symlinks created by the following aren't there or used on Windows:

node/tools/install.py

Lines 91 to 107 in a7b59d6

	# create/remove symlink
	link_path = abspath(install_path, 'bin/npm')
	if action == uninstall:
	action([link_path], 'bin/npm')
	elif action == install:
	try_symlink('../lib/node_modules/npm/bin/npm-cli.js', link_path)
	else:
	assert(0) # unhandled action type
	# create/remove symlink
	link_path = abspath(install_path, 'bin/npx')
	if action == uninstall:
	action([link_path], 'bin/npx')
	elif action == install:
	try_symlink('../lib/node_modules/npm/bin/npx-cli.js', link_path)
	else:
	assert(0) # unhandled action type

edit: Also note that bin/npm and bin/npx are actual files which are kept as files on Windows, but overwritten with the symlinks by install.py everywhere else.

[richardlau]

Turns out this is a one line change to vcbuild.bat: #23001

(Edit: more changes were necessary for the installer)