-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: missing defenitions from headers tarball #23167
Comments
The zlib symbols should all be taken care of – we have
|
The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball. |
I’m not sure but I don’t think it’s an issue – the only thing that could potentially be defined is |
* `V8_DEPRECATION_WARNINGS` is here for explicity. It is already defined in `node.gypi`, and `addon.gypi`. * `V8_IMMINENT_DEPRECATION_WARNINGS` added to warn addons authors. * `OPENSSL_THREADS` apears in the openSSL `.h` files, and was only defined via GYP for the node build. PR-URL: nodejs#23426 Fixes: nodejs#23167 Refs: nodejs#23122 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
I did a semi-thorough grep for symbols our deps use to customise their build, and found a few. First one might have helped find #23122 earlier.
Question is, should we define them, and how (probably via
common.gypi
)?@nodejs/build-files
The text was updated successfully, but these errors were encountered: