Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node core building instructions in one place #23491

Closed
trivikr opened this issue Oct 12, 2018 · 2 comments
Closed

Node core building instructions in one place #23491

trivikr opened this issue Oct 12, 2018 · 2 comments
Labels
good first issue Issues that are suitable for first-time contributors.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 12, 2018

Is your feature request related to a problem? Please describe.
Many Code and Learn participants faced problem to find the documentation for running single tests:

Describe the solution you'd like
Remove duplicate documentation and have single location where build instructions are defined
@trivikr trivikr added the good first issue Issues that are suitable for first-time contributors. label Oct 12, 2018
@fastereder
Copy link
Contributor

i´m working on this

fastereder added a commit to fastereder/node that referenced this issue Oct 12, 2018
@fastereder
doc: added info how to run single tests to BUILDING.md
f371b60 
The information on how to run single tests was missing in BUILDING.md.

Fixes: nodejs#23491
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Oct 15, 2018
@fastereder @BridgeAR
doc: add info how to run single tests to BUILDING.md
e07f43c 
The information on how to run single tests was missing in
BUILDING.md.

PR-URL: nodejs#23490
Fixes: nodejs#23491
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@trivikr
Copy link
Member Author

trivikr commented Oct 15, 2018

Reopening as the commit 5a30621 just adds instructions to run single test in BUILDING.md

The ask is to have instructions in single place - instead of repeating them in Pull Requests, BUILDING.md and TESTING.md

@trivikr trivikr reopened this Oct 15, 2018
jasnell pushed a commit that referenced this issue Oct 17, 2018
@fastereder @jasnell
doc: add info how to run single tests to BUILDING.md
9430ac2 
The information on how to run single tests was missing in
BUILDING.md.

PR-URL: #23490
Fixes: #23491
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
trivikr added a commit to trivikr/node that referenced this issue Oct 29, 2018
@trivikr
doc: moved test instructions to BUILDING.md
ed4934d 
Fixes: nodejs#23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md
@trivikr trivikr mentioned this issue Oct 29, 2018
Closed
2 tasks
targos pushed a commit that referenced this issue Nov 1, 2018
@trivikr @targos
doc: moved test instructions to BUILDING.md
539e123 
Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: #23949
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: moved test instructions to BUILDING.md trivikr/node
2 participants
@fastereder @trivikr