Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing semver-major change in v11.0.0 changelog #23846

Closed
targos opened this issue Oct 24, 2018 · 0 comments
Closed

Missing semver-major change in v11.0.0 changelog #23846

targos opened this issue Oct 24, 2018 · 0 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@targos
Copy link
Member

targos commented Oct 24, 2018

Modified close event behaviour landed in version 11.0.0 (it is ok:) but I haven't found it in semver-major changes in its changelog... If I don't look a bad way it would be fine to add this information... Thanks

Originally posted by @mareksrom in 8799f43#commitcomment-31025720

Original PR: #20611
@targos targos added the doc Issues and PRs related to the documentations. label Oct 24, 2018
Trott added a commit to Trott/io.js that referenced this issue Nov 16, 2018
@Trott
doc: update 11.0.0 changelog with missing commit
9ec8d49 
Fixes: nodejs#23846
This was referenced Nov 16, 2018
Closed
Closed
@danbev danbev closed this as completed in b32c5f0 Nov 20, 2018
targos pushed a commit that referenced this issue Nov 20, 2018
@Trott @targos
doc: update 11.0.0 changelog with missing commit
dd6349a 
PR-URL: #24404
Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@Trott @rvagg
doc: update 11.0.0 changelog with missing commit
9ab2bcf 
PR-URL: #24404
Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@Trott @refack
doc: update 11.0.0 changelog with missing commit
c7d1fa7 
PR-URL: nodejs#24404
Fixes: nodejs#23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update 11.0.0 changelog with missing commit Trott/io.js
1 participant
@targos