Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installer resources #2418

Closed
fhemberger opened this issue Aug 18, 2015 · 1 comment
Closed

Update installer resources #2418

fhemberger opened this issue Aug 18, 2015 · 1 comment
Labels
build Issues and PRs related to build files or the CI.

Comments

@fhemberger
Copy link
Contributor

After #2367 has landed, a few things have to be fixed on the Windows and OS X installers:

Regarding the Windows installer, you can remove the following lines (linking of iojs.exe to nodejs.exe):

On OS X, these lines have to be changed:

io.js icon on the installer must be replaced as well:
https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L28

Same for the OS X installer:
https://github.com/cjihrig/node-1/blob/rename/tools/osx-pkg.pmdoc/index.xml.tmpl#L24
@fhemberger fhemberger mentioned this issue Aug 18, 2015
Closed
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Aug 18, 2015
@fhemberger fhemberger mentioned this issue Aug 19, 2015
Closed
cjihrig pushed a commit to cjihrig/node that referenced this issue Aug 19, 2015
@fhemberger @cjihrig
Fix installers after rename
cc19570 
Addresses issues in nodejs#2418

Conflicts:
	src/res/node.ico
@fhemberger
Copy link
Contributor Author

Fixed in updated PR #2367

cjihrig pushed a commit to cjihrig/node that referenced this issue Aug 23, 2015
@fhemberger @cjihrig
installer: fix installers for node.js rename
f80d883 
This commit completes the io.js to Node.js rename in the
Windows installer.

Fixes: nodejs#2418
PR-URL: nodejs#2367
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
cjihrig pushed a commit that referenced this issue Aug 23, 2015
@fhemberger @cjihrig
installer: fix installers for node.js rename
45a2046 
This commit completes the io.js to Node.js rename in the
Windows installer.

Fixes: #2418
PR-URL: #2367
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@aliscco aliscco mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @fhemberger