Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: experimental napi_add_finalizer documented as stable api #24509

Closed
legendecas opened this issue Nov 20, 2018 · 4 comments
Closed

n-api: experimental napi_add_finalizer documented as stable api #24509

legendecas opened this issue Nov 20, 2018 · 4 comments
Assignees
@mhdawson

Comments

@legendecas
Copy link
Member

  • Version: 10.13.0
  • Platform: all
  • Subsystem: n-api

napi_add_finalizer is declared as experimental in node_api.h(here), yet it does not been documented as experimental in document.
@legendecas
Copy link
Member Author

/cc @gabrielschulhof @mhdawson

@mhdawson
Copy link
Member

@legendecas thanks I'll make sure to update that.

@mhdawson mhdawson assigned mhdawson and unassigned mhdawson Nov 22, 2018
mhdawson added a commit to mhdawson/io.js that referenced this issue Nov 22, 2018
@mhdawson
doc: mark napi_add_finalizer experimental
98954fd 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
@mhdawson mhdawson mentioned this issue Nov 22, 2018
Closed
3 tasks
@mhdawson
Copy link
Member

PR here #24572

Trott pushed a commit to Trott/io.js that referenced this issue Nov 24, 2018
@mhdawson @Trott
doc: mark napi_add_finalizer experimental
ce890a0 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Closed by ce890a0

@Trott Trott closed this as completed Nov 24, 2018
targos pushed a commit that referenced this issue Nov 24, 2018
@mhdawson @targos
doc: mark napi_add_finalizer experimental
d5b7f99 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@mhdawson @rvagg
doc: mark napi_add_finalizer experimental
5796c6a 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@mhdawson @refack
doc: mark napi_add_finalizer experimental
d5230f8 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 11, 2019
@mhdawson @BethGriggs
doc: mark napi_add_finalizer experimental
dd5bfd7 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@mhdawson @rvagg
doc: mark napi_add_finalizer experimental
32d8622 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhdawson mhdawson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: mark napi_add_finalizer experimental mhdawson/io.js
3 participants
@Trott @legendecas @mhdawson