Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-process-argv-0 #2477

Closed
joaocgreis opened this issue Aug 20, 2015 · 3 comments
Closed

Investigate flaky test test-process-argv-0 #2477

joaocgreis opened this issue Aug 20, 2015 · 3 comments
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Aug 20, 2015
@Trott
Copy link
Member

Trott commented Aug 24, 2015

Another example:

@Trott
Copy link
Member

Trott commented Aug 25, 2015

When this test dies, it seems to have something to do with a problem communicating from child to parent using stderr. The first line sent using console.error() makes it to the parent but the second one does not and then (for whatever reason, but I'm guessing totally related) stdout similarly just hangs.

Since the console.error() stuff is purely there for debugging purposes, I'm guessing the test can be made robust by simply removing the writes/reads to/from stderr.

If there is a (CentOS-specific?) problem around stderr or something similar, that's a bug that deserves its own test and fix. But it's not a bug with process.argv so I'm comfortable removing it here.

I'll go ahead and do that in a while if no one swoops in with an objection (or no one beats me to it).

Trott added a commit to Trott/io.js that referenced this issue Aug 25, 2015
@Trott
test: make test-process-argv-0 robust
ae77774 
Remove use of STDERR to avoid test flakiness on CentOS.

Fixes: nodejs#2477
@Trott Trott mentioned this issue Aug 25, 2015
Closed
Trott added a commit that referenced this issue Aug 26, 2015
@Trott
test: make test-process-argv-0 robust
972a57c 
Remove use of STDERR to avoid test flakiness on CentOS 5.

Use parent process exit event for assertion rather than child exit
event.

PR-URL: #2541
Fixes: #2477
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 26, 2015

Fixed in 972a57c

@Trott Trott closed this as completed Aug 26, 2015
Trott added a commit that referenced this issue Aug 27, 2015
@Trott @rvagg
test: make test-process-argv-0 robust
3492d2d 
Remove use of STDERR to avoid test flakiness on CentOS 5.

Use parent process exit event for assertion rather than child exit
event.

PR-URL: #2541
Fixes: #2477
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaocgreis @Trott