-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: more tests for PKCS#8 private keys #24928
Comments
@bnoordhuis If you can be a mentor and guide me, I would like to help out on this issue. |
@uttampawar Thanks. Just ask questions and I'll try to answer them. |
@uttampawar |
Can I work on this issue? |
Hi, Is this available to work on? |
@bnoordhuis Is this still pending? The C++ coverage seems to be pretty good around key parsing, but it does not necessarily reflect all possible inputs. |
Yes, 85546c2 resolves this - it should have had a Fixes: tag, not a Refs: tag. I'll close this out, thanks. |
We currently lack coverage for unencrypted PKCS#8 private keys (
-----BEGIN PRIVATE KEY-----
) with the sole exception oftest/fixtures/foafssl.key
used intest/parallel/test-https-foafssl.js
.Compare PKCS#1 private keys (
-----BEGIN RSA PRIVATE KEY-----
) for which we have ample coverage.I count three tests that cover encrypted PKCS#8 keys (
-----BEGIN ENCRYPTED PRIVATE KEY-----
):For unencrypted PKCS#8, it would be nice to have tests for at least RSA and DSA, with and without PEM attributes for bonus points. See
test/fixtures/foafssl.key
for an example of attributes.cc @sam-github - possibly relevant to your interests
The text was updated successfully, but these errors were encountered: