Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process,tty: allow reading/writing from duplex sockets : backport to node-8 #25204

Closed
shrikrishnaholla opened this issue Dec 24, 2018 · 5 comments
Assignees
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.

Comments

@shrikrishnaholla
Copy link

shrikrishnaholla commented Dec 24, 2018

  • Version: 8.14.1
  • Platform: Linux
  • Subsystem: process/tty

Based on @mcollina 's advice in #21654 (comment)

Incrementing libuv version (to 1.20.x+. Release note - 8.13.0) has caused a regression in 8.x that causes stdout, stderr to throw when you try to read from it.

Quoting @mcollina from the referenced PR

We should likely backport part of #23053 to Node 8.

@mcollina
Copy link
Member

cc @addaleax

@addaleax addaleax added libuv Issues and PRs related to the libuv dependency or the uv binding. v8.x labels Dec 26, 2018
@addaleax
Copy link
Member

Did we backport libuv updates without those fixes? 😕

We probably want these commits from v10.x:

I’ll try to get to it when I can, but if somebody else has the time, please go for it…

@mcollina mcollina self-assigned this Jan 5, 2019
@mcollina
Copy link
Member

mcollina commented Jan 5, 2019

We didn't.

However:

process.stdout.on('data', function(data) {
  process._rawDebug(data.toString())
})

Works in 8.15.0.

@shrikrishnaholla can you please post a working repro for this?

@mcollina
Copy link
Member

mcollina commented Jan 5, 2019

I did the backports in #25351.

@targos
Copy link
Member

targos commented Jul 21, 2019

#25351 landed

@targos targos closed this as completed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Development

No branches or pull requests

4 participants