-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on Win10, fs.stat() returns a stats with undefined blksize and blocks #25913
Comments
bnoordhuis
added
fs
Issues and PRs related to the fs subsystem / file system.
windows
Issues and PRs related to the Windows platform.
labels
Feb 4, 2019
@joyeecheung I think #20220 is responsible for this? blksize and blocks are passed up (or down, depending on how you look at it) from libuv to node_file.cc to getStatsFromBinding(). (Aside: blksize is fixed at 4096 in libuv but blocks is queried at runtime and meaningful.) |
3 tasks
PR: #26056 |
richardlau
added a commit
to richardlau/node-1
that referenced
this issue
Feb 15, 2019
libuv returns values for `blksize` and `blocks` on stat calls so do not coerce them into `undefined` on Windows. PR-URL: nodejs#26056 Fixes: nodejs#25913 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this issue
Feb 15, 2019
libuv returns values for `blksize` and `blocks` on stat calls so do not coerce them into `undefined` on Windows. PR-URL: #26056 Fixes: #25913 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this issue
Feb 28, 2019
libuv returns values for `blksize` and `blocks` on stat calls so do not coerce them into `undefined` on Windows. PR-URL: #26056 Fixes: #25913 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On windows 10,
blksize
andblocks
are undefined. This is a regression from v6 and v8 which are not affected.As expected, both
fs.stat()
andfs.statSync()
are affected.This is easy to demo in a powershell.
The text was updated successfully, but these errors were encountered: