Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Small" ICU build on big endian platforms fails #2601

Closed
sxa opened this issue Aug 28, 2015 · 1 comment
Closed

"Small" ICU build on big endian platforms fails #2601

sxa opened this issue Aug 28, 2015 · 1 comment
Assignees
@mhdawson
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.

Comments

@sxa
Copy link
Member

sxa commented Aug 28, 2015

If you build with --with-intl=small-icu (the default for the "make binary" target) then the icutrim command fails on big-endian platforms:

Options: {'verbose': 1, 'filterfile': 'icu_small.json', 'toolpath': '/dev/shm/node/out/Release', 'deltmpdir': 1, 'outfile': 'icudt55b.dat', 'datfile': '../../deps/icu/source/data/in/icudt55l.dat', 'locales': 'en,root', 'endian': 'big', 'tmpdir': '/dev/shm/node/out/Release/obj/gen/icutmp'}
icu_small.json: icutrim.py config: Trim down ICU to just a certain locale set, needed for node.js use.
udata_swap(): unknown data format 63.6e.76.74 ("cnvt")
icupkg: udata_swap(item 121) failed - U_UNSUPPORTED_ERROR
FAILED: /dev/shm/node/out/Release/icupkg -tb ../../deps/icu/source/data/in/icudt55l.dat /dev/shm/node/out/Release/obj/gen/icutmp/icudt55b.dat

@srl295 I'll aim to submit a PR with the patch we've used for this previously on our PPC repositories
@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. labels Aug 28, 2015
@sxa sxa mentioned this issue Aug 28, 2015
Closed
mhdawson pushed a commit that referenced this issue Sep 17, 2015
@mhdawson
build: fix icutrim when building small-icu on BE
1fa0cb8 
Fix a build error that occurs when icutrim is run to cut down
the ICU locale set on Big-Endian platforms when building with
--with-intl=small-icu (which is done by the "make binary" target).
This fixes the binary build on POWER platforms.

Fixes: #2601
PR-URL: #2602
Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
Fishrock123 pushed a commit that referenced this issue Sep 20, 2015
@Fishrock123
build: fix icutrim when building small-icu on BE
5905b14 
Fix a build error that occurs when icutrim is run to cut down
the ICU locale set on Big-Endian platforms when building with
--with-intl=small-icu (which is done by the "make binary" target).
This fixes the binary build on POWER platforms.

Fixes: #2601
PR-URL: #2602
Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
@mhdawson
Copy link
Member

Believe this was pulled into 4.1.1 through #2602, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhdawson mhdawson

Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fishrock123 @sxa @mhdawson