Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide on "How do I become a Node.js committer". #26287

Closed
mcollina opened this issue Feb 24, 2019 · 6 comments · Fixed by #38056
Closed

Add a guide on "How do I become a Node.js committer". #26287

mcollina opened this issue Feb 24, 2019 · 6 comments · Fixed by #38056
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. meta Issues and PRs related to the general management of the project.

Comments

@mcollina
Copy link
Member

mcollina commented Feb 24, 2019

This is a meta issue, but it's something that it is not clear to a newcomer to the project. While the answer is simple "contribute!", they might look for some more info.

This came from a twitter exchange with @mikeal https://twitter.com/mikeal/status/1099729128813518848, who wrote https://medium.com/the-node-js-collection/healthy-open-source-967fa8be7951 (a long time ago!).

@mcollina mcollina added the meta Issues and PRs related to the general management of the project. label Feb 24, 2019
@richardlau
Copy link
Member

It wasn't perfect, but we used to do a better job of this.

A long time ago we used to say this in CONTRIBUTING.md:

The Node.js project has an open governance model and welcomes new contributors.
Individuals making significant and valuable contributions are made
Collaborators and given commit-access to the project. See the
GOVERNANCE.md document for more information about how this
works.

And GOVERNANCE.md used to say:

Individuals identified by the TSC as making significant and valuable
contributions across any Node.js repository may be made Collaborators and given
commit access to the project. Activities taken into consideration include (but
are not limited to) the quality of:

  • code commits and pull requests
  • documentation commits and pull requests
  • comments on issues and pull requests
  • contributions to the Node.js website
  • assistance provided to end users and novice contributors
  • participation in Working Groups
  • other participation in the wider Node.js community

If individuals making valuable contributions do not believe they have been
considered for commit access, they may log an issue or contact a TSC member
directly.

@mcollina
Copy link
Member Author

I agree.

@tniessen tniessen changed the title Add a guide on "How do I become a Node.js commmitter". Add a guide on "How do I become a Node.js committer". Feb 25, 2019
@richardlau
Copy link
Member

Just to follow up, the best we currently have is the Collaborator Nominations section of GOVERNANCE.md, although this is written more for the person making the nomination as opposed to the person who would like to become a collaborator.

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2019

I think we should restore some of the original text, somewhere.

@carolinedarling
Copy link

carolinedarling commented May 21, 2019

I want to note that this is still an issue. As someone new to open-source and contributing, I think Node.js could do a lot better job welcoming new contributors. Reading the CONTRIBUTING.md just now, I wasn't sure if new contributors were even welcome, or how to get involved. This could be rewritten/restored to help new people feel more welcome.

@jasnell jasnell added doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Jun 26, 2020
srknzl added a commit to srknzl/node that referenced this issue Apr 3, 2021
@tniessen
Copy link
Member

Please review #38056.

aduh95 pushed a commit that referenced this issue May 5, 2024
Fixes: #26287
PR-URL: #38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this issue May 8, 2024
Fixes: nodejs#26287
PR-URL: nodejs#38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue May 8, 2024
Fixes: #26287
PR-URL: #38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
Fixes: #26287
PR-URL: #38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this issue Jun 20, 2024
Fixes: nodejs#26287
PR-URL: nodejs#38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
Fixes: nodejs#26287
PR-URL: nodejs#38056
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants