Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: configure --with-intl=full-icu warns 3x #26860

Closed
srl295 opened this issue Mar 22, 2019 · 3 comments · Fixed by #27031
Closed

tools: configure --with-intl=full-icu warns 3x #26860

srl295 opened this issue Mar 22, 2019 · 3 comments · Fixed by #27031
Assignees
@srl295
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Mar 22, 2019

Just the place for a Snark! I have said it thrice. What I tell you three times is true. —L. Carroll

  • Version: master 01a1296
  • Platform: Mac
  • Subsystem: tools
$ ./configure --with-intl=full-icu
Warning: Not downloading package "icu". You could pass "--download=all"
    (Windows: "download-all") to try auto-downloading it.
Warning: Not downloading package "icu". You could pass "--download=all"
    (Windows: "download-all") to try auto-downloading it.
Warning: Not downloading package "icu". You could pass "--download=all"
    (Windows: "download-all") to try auto-downloading it.
WARNING: * ECMA-402 (Intl) support didn't find ICU in deps/icu..
ERROR: Cannot build Intl without ICU in deps/icu.
       Fix, or disable with "--with-intl=none"

One exactly duplicate warning would suffice.
@srl295 srl295 self-assigned this Mar 22, 2019
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Mar 22, 2019
@refack
Copy link
Contributor

refack commented Mar 22, 2019

Might be resolved by #26725

@srl295
Copy link
Member Author

srl295 commented Mar 22, 2019

@refack at least, i won't try to fix it until that lands! thanks.

@richardlau richardlau mentioned this issue Mar 31, 2019
Merged
2 tasks
@richardlau
Copy link
Member

Proposed fix: #27031

richardlau added a commit to richardlau/node-1 that referenced this issue Apr 3, 2019
@richardlau
build: only emit download ICU warnings once
b180a15 
The check that the user specified `icu` in `--download` only needs to be
done once and not for each entry in `tools/icu/current_ver.dep`.

Fixes: nodejs#26860

PR-URL: nodejs#27031
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Apr 4, 2019
@richardlau @BethGriggs
build: only emit download ICU warnings once
5199a28 
The check that the user specified `icu` in `--download` only needs to be
done once and not for each entry in `tools/icu/current_ver.dep`.

Fixes: #26860

PR-URL: #27031
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Apr 9, 2019
@richardlau @BethGriggs
build: only emit download ICU warnings once
ab5dbf9 
The check that the user specified `icu` in `--download` only needs to be
done once and not for each entry in `tools/icu/current_ver.dep`.

Fixes: #26860

PR-URL: #27031
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Apr 10, 2019
@richardlau @BethGriggs
build: only emit download ICU warnings once
a58437d 
The check that the user specified `icu` in `--download` only needs to be
done once and not for each entry in `tools/icu/current_ver.dep`.

Fixes: #26860

PR-URL: #27031
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: only emit download ICU warnings once richardlau/node-1
3 participants
@refack @srl295 @richardlau