Module stat cache keeps broken results in cache

[ZauberNerd]

• Version: v11.11.0
• Platform: Linux bb-laptop 5.0.4-arch1-1-ARCH deps: update openssl to 1.0.1j #1 SMP PREEMPT Sat Mar 23 21:00:33 UTC 2019 x86_64 GNU/Linux
• Subsystem: module

Actual behavior:
requireing a non-existing file throws a MODULE_NOT_FOUND error, creating the file afterwards and trying to require again still throws.

Expected behavior:
The second call to require should resolve to the actual file content.

Try the following three lines in a REPL (Node v11.10.1 vs Node v11.11.0):

require('./non-existent.json');
require('fs').writeFileSync('./non-existent.json', '1');
require('./non-existent.json');

It seems like the bug was introduced with this commit: d94f4c23fe - I built Node.js with this commit and with its parent commit and was able to observe the above mentioned behavior.

[addaleax]

/cc @BridgeAR

[thetutlage]

Yes, facing the exact same issue. Discovered while I was writing some tests

[lwr]

not works for paths cache (node_modules)

test case

1. create 1.js

   // 1.js
   try { require('anything-needs-lookup'); } catch (e) {}
   require('./any-related-js');
   require('fs').mkdirSync('./node_modules');
   require('fs').writeFileSync('./node_modules/non-existent.json', '1');
   // module._compile('', ''); // we use this hack to workaround this issue
   console.log(require('non-existent.json'))

2. run command

   rm -rf node_modules && echo '' > any-related-js.js && node 1

Actual behavior:
test in node 13.6.0

internal/modules/cjs/loader.js:976
  throw err;
  ^

Error: Cannot find module 'non-existent.json'
Require stack:
- /path/to/test/1.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:973:15)
    at Function.Module._load (internal/modules/cjs/loader.js:855:27)
    at Module.require (internal/modules/cjs/loader.js:1033:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/path/to/test/1.js:10:1)
    at Module._compile (internal/modules/cjs/loader.js:1144:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1164:10)
    at Module.load (internal/modules/cjs/loader.js:993:32)
    at Function.Module._load (internal/modules/cjs/loader.js:892:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/path/to/test/1.js' ]
}

Expected behavior:
-- (uncomment the line that workaround this problem) --
output 1

[BridgeAR]

@lwr your issue is unrelated to the issue originally mentioned.

I am not certain if your example ever used to work. I tried almost all Node.js versions down to v6.17.1 and all threw the Cannot find module error. It is not really intended to create not found node_modules on the fly during the loading phase and to reload them in the same phase.

[lwr]

@BridgeAR I am sorry for something wrong in the test case

one line added to the test

try { require('anything-needs-lookup'); } catch (e) {}
+ require('./any-related-js');

and the test command changed to

rm -rf node_modules && echo '' > any-related-js.js && node 1

the test is passed in 10.17.0 / failed in 13.6.0