Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-tls-sni-server-client #27219

Closed
lpinca opened this issue Apr 14, 2019 · 1 comment
Closed

Investigate flaky parallel/test-tls-sni-server-client #27219

lpinca opened this issue Apr 14, 2019 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. tls Issues and PRs related to the tls subsystem.

Comments

@lpinca
Copy link
Member

lpinca commented Apr 14, 2019 •
edited
Loading

  • Version: master
  • Platform: macOS
  • Subsystem: tls
=== release test-tls-sni-server-client ===
Path: parallel/test-tls-sni-server-client
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:182:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-server-client.js

Refs: #26910 (comment)
@lpinca lpinca added flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. tls Issues and PRs related to the tls subsystem. labels Apr 14, 2019
@refack refack mentioned this issue Apr 14, 2019
Merged
4 tasks
refack added a commit to refack/node that referenced this issue Apr 21, 2019
@refack
test: mark some known flakes
528d100 
PR-URL: nodejs#27225
Refs: nodejs#26910
Refs: nodejs#27219
Refs: nodejs#26938
Refs: nodejs#23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@lpinca lpinca mentioned this issue Apr 26, 2019
Closed
2 tasks
lpinca added a commit to lpinca/node that referenced this issue May 1, 2019
@lpinca
test: refactor and deflake test-tls-sni-server-client
8d63f4c 
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300
@Trott
Copy link
Member

Trott commented May 2, 2019

Fixed in bc0a330

@Trott Trott closed this as completed May 2, 2019
Trott pushed a commit to Trott/io.js that referenced this issue May 2, 2019
@lpinca @Trott
test: refactor and deflake test-tls-sni-server-client
bc0a330 
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300

PR-URL: nodejs#27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue May 4, 2019
@lpinca @targos
test: refactor and deflake test-tls-sni-server-client
df4246e 
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: #27219
Refs: #27300

PR-URL: #27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@refack @MylesBorins
test: mark some known flakes
915ea2a 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@refack @MylesBorins
test: mark some known flakes
fe21dd3 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: refactor and deflake test-tls-sni-server-client lpinca/node
2 participants
@Trott @lpinca