-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky parallel/test-http-dns-error.js #27487
Labels
dns
Issues and PRs related to the dns subsystem.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
http
Issues or PRs related to the http subsystem.
Comments
mscdex
added
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
dns
Issues and PRs related to the dns subsystem.
http
Issues or PRs related to the http subsystem.
labels
Apr 30, 2019
3 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this issue
May 3, 2019
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: nodejs#27500 Fixes: nodejs#27487 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dns
Issues and PRs related to the dns subsystem.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
http
Issues or PRs related to the http subsystem.
On test-azure_msft-win2016-x64-4 with VS2017, parallel/test-http-dns-error.js fails with:
I think that the
errCode
could be made an array of strings instead of being set to a string to allow for multiple acceptable error codes.The text was updated successfully, but these errors were encountered: