Add timeout and killSignal options to child_process spawn() and fork()

[ehmicky]

Is your feature request related to a problem? Please describe.
The timeout and killSignal options are available in execFile[Sync](), exec[Sync](), spawnSync() but not in spawn() nor fork().

Those methods could be useful for spawn() and fork() too. For example, projects like execa (by @sindresorhus) use userland code to bring those options to spawn().

Describe the solution you'd like
Add those options to spawn() and fork().

[mscdex]

maxBuffer doesn't make sense for spawn()/fork() because nothing is being buffered internally (outside of normal stream behavior).

[ehmicky]

Yes you're correct, it does not make sense. I changed the original post to only target timeout and killSignal.

[sam-github]

spawn and fork are thought to be used mostly for longer running processes, not one shots like exec and spawnSync, which is why I suppose the options were not implemented.

However, I can see why that assumption isn't necessarily true, and consistency is useful.

Do you have time and interest in contributing this feature?

[ehmicky]

Hi @sam-github, thanks! Yes I can submit a PR.

[sam-github]

@ehmicky note that the feature will need tests, which will take more time than the implementation code/docs itself. Just so you know what you are getting into :-)

[ehmicky]

Yes I was expecting that :)

[Linkgoron]

I'll take a shot at this.