Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic: Start menu item installed by Node 12 uses old/outdated node icon #27934

Closed
mikemaccana opened this issue May 28, 2019 · 13 comments
Closed
Labels
build Issues and PRs related to build files or the CI.

Comments

@mikemaccana
Copy link
Contributor

mikemaccana commented May 28, 2019

Start menu item installed by Node 12 uses old/outdated node icon (last updated Aug 2015):

image

It should look more like this image (per current branding from Feb 2016):

image

@refack
Copy link
Contributor

refack commented May 28, 2019

@mikemaccana
Copy link
Contributor Author

mikemaccana commented May 28, 2019

Any thoughts on using the green gem?

image

Or we can use the 'JS' hexagon instead if we prefer.

@mikemaccana
Copy link
Contributor Author

Using the JS hexagon instead:

image

Both are produced from the SVG on the node website, with the other resources removed, and then converted using https://icoconvert.com/

@mikemaccana
Copy link
Contributor Author

mikemaccana commented May 28, 2019

The last change in file history is moving from the iojs icon to the node icon in Aug 2015, prior to the current node branding existing in Feb 2016

@refack
Copy link
Contributor

refack commented May 28, 2019

Any thoughts on using the green gem?

I'm +1 on the green gem. But I love that the old one is 3D. But2 I'm not sure the 3D look is OpenJSF blessed.

@mikemaccana
Copy link
Contributor Author

I've made a poll on Twitter - please vote there! https://twitter.com/mikemaccana/status/1133393051328679939

@refack
Copy link
Contributor

refack commented May 28, 2019

FTR the node.ico file has packs 5 resolutions
image

@mikemaccana
Copy link
Contributor Author

Thanks @refack I'll make sure they're all there. What tool are you using to inspect it?

@refack
Copy link
Contributor

refack commented May 28, 2019

Surprisingly (at least to me) the best one I found already installed on my computer is MSVS. But I had success with a several googlable tools in the past, if I remember correctly png2ico was useful (maybe also ffmpeg but I'm not 100% sure)

@silverwind
Copy link
Contributor

Hexagon source file is here:

https://github.com/nodejs/nodejs.org/blob/master/static/images/logo-hexagon.svg

There's also a 32px PNG:

https://github.com/nodejs/nodejs.org/blob/master/static/favicon.png

@silverwind silverwind added the build Issues and PRs related to build files or the CI. label May 29, 2019
@himself65
Copy link
Member

it's the old green gem on my windows. but I like the new one

@mikemaccana
Copy link
Contributor Author

Done. I added a 256 x 256 just in case.
image

@mikemaccana
Copy link
Contributor Author

Updated the Windows icon for the fixed hexagon svg per nodejs/nodejs.org#2316

Process (just in case this needs to be repeated)

  • change SVG canvas to 150 'pixels' square (this adds a small amount of space at the top and bottom, and squares off the image).
  • Export to SVG at 256 pixels square
  • Use iconvert.com, export 16, 32, 48, 64 , 128 and 256 versions
  • Copy to src/res/node.ico

targos pushed a commit that referenced this issue Jul 20, 2019
PR-URL: #28524
Fixes: #27934
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Oct 17, 2019
PR-URL: #28524
Fixes: #27934
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants