__atomic_is_lock_free undefined on clang

[devsnek]

cc @addaleax

out/Release/obj.target/libnode/src/node.o: In function `node::RegisterSignalHandler(int, void (*)(int, siginfo_t*, void*), bool)':
node.cc:(.text+0x17b4): undefined reference to `__atomic_is_lock_free'

i'm on debian+wsl

update: adding -latomic fixes this, but i'm not sure where to put that within our build tooling.

[devsnek]

this appears to fix it, is this correct?

diff --git a/node.gyp b/node.gyp
index 56377d6a0c..7913599e4e 100644
--- a/node.gyp
+++ b/node.gyp
@@ -289,6 +289,9 @@
           '-Wl,-bnoerrmsg',
         ],
       }],
+      ['OS=="linux" or OS=="mac"', {
+        'libraries': ['-latomic'],
+      }],
     ],
   },

[addaleax]

@devsnek Yeah, if it passes CI then that looks good to me :) I’m surprised that CI for #27775 passed without it, though, and we didn’t really need it so far even though we (and V8) use atomic operations a lot…

[zombieleet]

I just stumbled into this exact issue as well, the PR that fixes this issue did not work for me, removing llvm_version!=0.0 (I have llvm installed on my computer) from node.gyp fixes the issue for me.

Kernel: 5.18.0-14parrot1-amd64
Arch: X86_64