Error stack trace sent to the inspector contains ANSI escape codes #28287
Comments
joyeecheung
added
inspector
2 tasks
2 tasks
targos
pushed a commit
that referenced
this issue
Jul 2, 2019
Previously the enhancement were done right after emitting `'uncaughtException'`, which meant by the time we knew the exception was fatal in C++, the error.stack had already been patched. This patch moves those routines to be called later during the fatal exception handling, and split them into two stages: before and after the inspector is notified by the invocation of `V8Inspector::exceptionThrown`. We now expand the stack to include additional informations about unhandled 'error' events before the inspector is notified, but delay the highlighting of the frames until after the inspector is notified, so that the ANSI escape sequences won't show up in the inspector console. PR-URL: #28308 Fixes: #28287 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this issue
Jul 2, 2019
Previously the enhancement were done right after emitting `'uncaughtException'`, which meant by the time we knew the exception was fatal in C++, the error.stack had already been patched. This patch moves those routines to be called later during the fatal exception handling, and split them into two stages: before and after the inspector is notified by the invocation of `V8Inspector::exceptionThrown`. We now expand the stack to include additional informations about unhandled 'error' events before the inspector is notified, but delay the highlighting of the frames until after the inspector is notified, so that the ANSI escape sequences won't show up in the inspector console. PR-URL: #28308 Fixes: #28287 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refs: #27052
One solution may be skipping
node/lib/internal/process/execution.js
Line 170 in a33c3c6
If the inspector is listening. Another alternative is to pass a different stack trace to
V8Inspector::exceptionThrown().Although..it might even be possible to customize the styles displayed in the DevTools but then I don't suppose it's easy to add that to the inspector protocol so that every inspector client handles it properly.
The text was updated successfully, but these errors were encountered: