Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: OutgoingMessage streamlike #28969

Open
7 of 9 tasks
ronag opened this issue Aug 5, 2019 · 3 comments
Open
7 of 9 tasks

http: OutgoingMessage streamlike #28969

ronag opened this issue Aug 5, 2019 · 3 comments
Labels
http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Aug 5, 2019

http OutgoingMessage is missing some methods, properties and behaviours to make it "truly" "streamlike":

Furthermore the destroy event ordering does not seem to be fully consistent with the stream implementation (needs further investigation).

@ronag ronag changed the title http: outgoing missing properties http: OutgoingMessage as Writable Aug 5, 2019
@ronag ronag changed the title http: OutgoingMessage as Writable http: OutgoingMessage streamlike Aug 5, 2019
@mcollina
Copy link
Member

mcollina commented Aug 5, 2019

Great initiative, definitely +1 to add all of these!

@addaleax addaleax added http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem. labels Aug 5, 2019
@awwright
Copy link
Contributor

awwright commented Jul 5, 2020

Is there some reason that OutgoingMessage is not an ancestor of Writable?

@ronag
Copy link
Member Author

ronag commented Jul 5, 2020

Performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants