Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: OutgoingMessage instanceof Writable #28971

Closed
ronag opened this issue Aug 5, 2019 · 3 comments
Closed

http: OutgoingMessage instanceof Writable #28971

ronag opened this issue Aug 5, 2019 · 3 comments

Comments

@ronag
Copy link
Member

ronag commented Aug 5, 2019

Would it be an idea to make OutgoingMessage inherit the Writable prototype but where we override all methods. Just in order to make msg instanceof Writable work?
@ronag
Copy link
Member Author

ronag commented Aug 5, 2019

ping @mcollina

@ronag ronag mentioned this issue Aug 5, 2019
Open
9 tasks
@mcollina
Copy link
Member

mcollina commented Aug 5, 2019 •
edited
Loading

I tried this in the past, but I got a significant performance drop. I'm happy to review a PR, if it has no performance loss.

rexagod added a commit to rexagod/node that referenced this issue Jun 14, 2020
@rexagod
http: make http.OutgoingMessage inherit Stream.Writable
85247a0 
Fixes: nodejs#28971
@rexagod rexagod mentioned this issue Jun 14, 2020
Closed
4 tasks
@mcollina
Copy link
Member

I would recommend we close this issue as it’s likely not doable without a significant slowdown in the current state of affairs.

@ronag ronag closed this as completed Jun 14, 2020
@daeyeon daeyeon mentioned this issue Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: make http.OutgoingMessage inherit Stream.Writable rexagod/node
2 participants
@mcollina @ronag