Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.read documentation errors #29266

Closed
jzombie opened this issue Aug 22, 2019 · 6 comments
Closed

fs.read documentation errors #29266

jzombie opened this issue Aug 22, 2019 · 6 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Comments

@jzombie
Copy link

jzombie commented Aug 22, 2019

https://nodejs.org/api/fs.html#fs_fs_read_fd_buffer_offset_length_position_callback

References to buffer and offset are indicative of writing, when they should be for reading.

fs-read-bug
@ronag
Copy link
Member

ronag commented Aug 22, 2019

Good first PR?

@ouadie-lahdioui
Copy link

This is your chance @HACHIMIam!!

@HACHIMIam
Copy link

HACHIMIam commented Aug 22, 2019 •
edited
Loading

done #29270 @ouadie-lahdioui

@Fishrock123 Fishrock123 added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Aug 22, 2019
@sarthak0906
Copy link

Is this issue still open
I would like to contribute

@sarthak0906 sarthak0906 mentioned this issue Nov 29, 2019
Closed
@gireeshpunathil
Copy link
Member

@sarthak0906 - looks like that is being worked upon. I suggest you review

and then

should get you a candidate for contribution!

jasnell added a commit to jasnell/node that referenced this issue Jul 6, 2020
@jasnell
doc: fixup docs for fs.read
e7c7abe 
Fixes: nodejs#29266
@jasnell jasnell mentioned this issue Jul 6, 2020
Closed
3 tasks
@addaleax
Copy link
Member

addaleax commented Jul 7, 2020

This has been fixed by #29270, so I think this can be closed

@addaleax addaleax closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fixup docs for fs.read jasnell/node
8 participants
@addaleax @Fishrock123 @jzombie @ouadie-lahdioui @ronag @gireeshpunathil @HACHIMIam @sarthak0906