Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'async' is a reserved word in Python >= 3.7 #29326

Closed
cclauss opened this issue Aug 26, 2019 · 1 comment
Closed

'async' is a reserved word in Python >= 3.7 #29326

cclauss opened this issue Aug 26, 2019 · 1 comment
Labels
build Issues and PRs related to build files or the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. python PRs and issues that require attention from people who are familiar with Python.

Comments

@cclauss
Copy link
Contributor

cclauss commented Aug 26, 2019 •
edited
Loading

$ python3.7 ./configure.py ; NODE=$(which node) make test # generates -->

Failed to parse config file: Type names and field names cannot be a keyword: 'async'

That message is generated in inspector_protocol/code_generator.py because 'async' is a Python keyword in Python >= 3.7 and deps/v8/src/inspector/inspector_protocol_config.json contains async as a dict key.

UPDATE: This is now fixed in upstream https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 and now needs to be downstreamed.
This was referenced Aug 26, 2019
Closed
Closed
@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. labels Aug 27, 2019
@bnoordhuis bnoordhuis mentioned this issue Aug 27, 2019
Closed
@bnoordhuis
Copy link
Member

#29340

This was referenced Aug 27, 2019
Closed
Closed
sam-github pushed a commit that referenced this issue Sep 5, 2019
@bnoordhuis @sam-github
tools: python3 compat for inspector code generator
ac43504 
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in python 3, and rejected
by the namedtuple constructor. Rename it to "_async" to avoid the clash.

Fixes: #29326
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Sep 10, 2019
@bnoordhuis
tools: python3 compat for inspector code generator
b2d25ce 
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in python 3.7, and rejected
by the namedtuple constructor. Rename it to "async_" to avoid the clash.

Fixes: nodejs#29326
@cclauss cclauss mentioned this issue Sep 10, 2019
Closed
@cclauss cclauss added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Sep 11, 2019
@cclauss cclauss mentioned this issue Sep 11, 2019
Closed
@cclauss cclauss mentioned this issue Sep 13, 2019
Closed
@sam-github sam-github mentioned this issue Sep 16, 2019
Closed
4 tasks
targos pushed a commit that referenced this issue Sep 20, 2019
@bnoordhuis @targos
tools: python3 compat for inspector code generator
992c051 
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in python 3.7, and rejected
by the namedtuple constructor. Rename it to "async_" to avoid the clash.

Fixes: #29326

PR-URL: #29340
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this issue Sep 25, 2019
@bnoordhuis @BridgeAR
tools: python3 compat for inspector code generator
bc7cc34 
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in python 3.7, and rejected
by the namedtuple constructor. Rename it to "async_" to avoid the clash.

Fixes: #29326

PR-URL: #29340
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
3 participants
@bnoordhuis @Fishrock123 @cclauss